This repository has been archived by the owner on Jan 28, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 48
Add ability to configure the number of max concurrent reconciles #154
Merged
Azadehkhojandi
merged 9 commits into
Azure:master
from
stuartleeks:esck/add-configurable-reconcilers
Feb 17, 2020
Merged
Add ability to configure the number of max concurrent reconciles #154
Azadehkhojandi
merged 9 commits into
Azure:master
from
stuartleeks:esck/add-configurable-reconcilers
Feb 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Looks good to me. |
…m/stuartleeks/azure-databricks-operator into esck/add-configurable-reconcilers
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Azadehkhojandi
approved these changes
Feb 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I will merge the PR if the build passes
EliiseS
added a commit
to EliiseS/azure-databricks-operator
that referenced
this pull request
Feb 19, 2020
…re#154) * Add MAX_CONCURRENT_RUN_RECONCILES to yaml
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update is to address the issue with the operator being unable to handle the load raised here: #153
We re-ran the load test with
MaxConcurrentReconciles
set 10 instead of the default 1 resulting in noticeable improvements seen below.Here we can see the where to load ramps up to 25 users(runs)
As the work load increases we can see the average wait time climb to 5 seconds vs the previous 10 seconds.
The queue depth is also lower than before at around 30 vs around 40 previously.
We feel this is a good solution for being able to configure to controller to be able to handle more load.