Fixed: Made object id optional

[roshan-sy]

Please make sure the code is following contribution guidelines in CONTRIBUTING.md

• : This PR has a corresponding issue open in the Repository.
• : Approach is signed off on the issue.

Fixes: #1132

Made object id optional while deleting the refs (i.e. heads and tags)

Changes done:

1. Flow: Object id is resolved on the go and provided it to API, As Object Id is not optional in API.
2. Code: E2E test case added specifically for delete ref (Create and delete ref)

[gauravsaralMs]

I would suggest adding some UTs also, specially for negative cases

[gauravsaralMs]

Suggested change

	logger.error('ref not found')
	return
	raise CLIError("Failed to find object_id for ref " + name + ". Please provide object_id.")

[gauravsaralMs]

Suggested change

	if not ref:
	if not ref or len(ref) > 1:

[gauravsaralMs]

just to be sure we are not getting multiple id's from service because in that case we can't be sure which one to delete

[roshan-sy]

Working on Adding more Unit test cases

[gauravsaralMs]

@roshan-sy : unit tests are present in https://github.com/Azure/azure-devops-cli-extension/blob/master/azure-devops/azext_devops/test/repos/test_ref.py

btw: nice work adding E2E test cases, the reason we need unit test cases as well is that unit test cases are easier/ fast to run and can be used to validate small changes

one unit test is already present for delete_ref

azure-devops-cli-extension/azure-devops/azext_devops/test/repos/test_ref.py

Lines 87 to 96 in 211d0c5

	def test_delete_ref(self):
	response = delete_ref(name='sample_ref',
	object_id='1234567890',
	organization=TEST_DEVOPS_ORG_URL,
	project='sample_project')
	# assert
	self.mock_update_refs.assert_called_once_with(project='sample_project',
	ref_updates=ANY,
	repository_id=None)

[roshan-sy]

Got it, I'll add the UT as well,