-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use x86_64 version of artifact tool for M1 macs (using Rosetta) #1210
Conversation
@dalemyers to double-check, have you been able to verify this on your M1? |
I'm actually trying as we speak, but my M1 for testing has some problems which are getting in the way. Will be a day or two before I can actually run it I suspect. However, in my testing beforehand, this definitely won't make things worse. (And I have confirmed that it works as expected on an intel mac). |
|
||
# For M1 macs, there is no version of artifact tool. However, the x86_64 | ||
# version can run under Rosetta, so we use that instead. | ||
if os_name == "Darwin" and arch == "amd64": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dalemyers I tested using your branch with a M1 processor but it didn't work, so I changed from amd64 to arm64 (M1 arch), rebuilt and azure can respond to M1 based requests. Would you consider adding arm64?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that's likely a mistake on my part. I haven't yet managed to test this on an M1 mac, so wouldn't have seen this typo. I'll update with both to be sure. Thanks for the heads up!
@gauravsaralMs / @roshan-sy looks like one of you has to approve before this can merge. I approve on behalf of the Azure Artifacts Packaging team. |
have the same error on Windows ARM64 VM |
Fixes: #1006
There is no version of artifacttool which runs natively on an M1 mac (which uses Apple Silicon / ARM). This PR overrides the architecture to
x86_64
on those macs so that the "intel" version is downloaded, which will run under Rosetta.There are 2 alternatives: