Fixing issue with a lease existing on start #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 7, 2022 18:23
… already exists: 1. 409, when the we can't meet the "if not exist" constraint (perfectly fine, just return what's there) 2. 412, when the blob already exists and the Azure Blob storage lease is active.
|
/azp run Azure.azure-event-hubs-go |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jhendrixMSFT
approved these changes
Nov 8, 2022
…datable in a background renewal function.
|
/azp run Azure.azure-event-hubs-go |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
The test run is not linking up in here, but I fixed a race condition in the leaser as well that came up while the tests were running. The leaser holds onto it's last loaded lease and renews it in the background, which was causing a race condition between this and the scheduler object. Fixed, by using an atomic.Value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storage failures don't return a Response, and require us to do an errors.As() and check the returned error instead. This checks for the two codes that can come back if the blob already exists (409) or if the blob exists and it has an active storage lease (412).
Fixes #276