Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding RBAC changes, partially done #444

Merged
merged 7 commits into from
Jun 25, 2019
Merged

Adding RBAC changes, partially done #444

merged 7 commits into from
Jun 25, 2019

Conversation

ShubhaVijayasarathy
Copy link
Contributor

No description provided.

g2vinay pushed a commit to g2vinay/azure-sdk-for-java that referenced this pull request Jun 20, 2019
@conniey
Merge latest changes from Azure/azure-event-hubs#444 (Azure#3511)
9cc2dc8 
* Update Apache Proton-J dependency (0.29.0 --> 0.31.0) (Azure#407)

* PartitionReceiver - add a method that provides an EventPosition which corresponds to an EventData returned last by the receiver (Azure#408)

* Support IsPartitionEmpty property for PartitionRuntimeInformation (Azure#399)

* Move setPrefetchCount API to the ReceiverOptions class from the PartitionReceiver and update the settings of Default & Max Prefetch count (Azure#410)

This pull request includes two major changes related to Prefetch API.

1) Move setPrefetchCount API to the ReceiverOptions class so that prefetch value specified by a user can be used instead of using default value when communicating to the service during link open and initializing a receiver. This change also addresses the receiver stuck issue caused by setPrefetchAPI in a race condition.

2) Change the default value and set the upper bound of the prefetch count. Note that prefetch count should be greater than or equal to maxEventCount which can be set when either a) calling receive() API or b) implementing the getMaxEventCount API of the SessionReceiverHandler interface.

* Fixes several issues in the reactor related components (Azure#411)

This pull request contains the following changes.

1) Finish pending tasks when recreating the reactor and make sure pending calls scheduled on the old reactor get complete.
2) Fix the session open timeout issue which can result in NPE in proton-J engine.
3) Make session open timeout configurable and use the value of OperationTimeout.
4) Update the message of exceptions and include an entity name in the exception message.
5) API change - use ScheduledExecutorService.
6) Improve tracing.

* Implement comparable on EventData (Azure#395)

* Update receive/send link creation logic and improve tracing (Azure#414)

* Prep for releasing client 2.0.0 and EPH 2.2.0 (Azure#415)

* Ensure that links are closed when transport error occurrs (Azure#417)

* ensure links are recreated on transport/connection failure
* update API document for EventProcessorOptions class
* add traces for link create/close case

* Prep for releasing client 2.1.0 and EPH 2.3.0 (Azure#418)

* Update prefetch sendflow logic and increment version for new release (Azure#420)

* Fix args for proxy auth call to Authenticator (Azure#421)

* Prepare EPH 2.3.4 release (Azure#423)

* Prepare EPH 2.4.0 release (Azure#423) (Azure#424)

* Handle proton:io errors with meaningful error msg (Azure#427)

* Handle proton:io errors with meaningful error msg

* Use Proton-supplied message if present

* Minor changes to lease scanner (Azure#428)

* Add logging if the scanner threw an exception.
* Change logging level to warn when scanner shuts down for any reason.
* Scanner can call EventProcessorOptions.notifyOfException, which calls user code. Change notifyOfException to defensively catch any exceptions coming out of user code.

* Make EventData.SystemProperties completely public (Azure#435)

Porting testability changes from .NET Core to Java: provide full access to EventData's SystemProperties so that a complete EventData can be fabricated in tests.

* Digest Support: init first connection with null headers (Azure#431)

Related to Azure/qpid-proton-j-extensions#10

* Fix lease scanner issues when Storage unreachable (Azure#434)

This fix is for issue Azure#432. There are two parts:

AzureStorageCheckpointLeaseManager performs certain Storage actions within a forEach. If those actions fail, the StorageException gets wrapped in a NoSuchElementException. Catch those and strip off the NoSuchElementException, then handle the StorageException in the existing way.

The unexpected NoSuchElementExceptions were not being caught anywhere and the scanner thread was dying without rescheduling itself. Added code in PartitionMananger.scan to catch any exceptions that leak out of PartitionScanner and reschedule the scanner unless the host instance is shutting down.

* message receiver - fix null pointer error and ensure that receive link is recreated upon a failure (Azure#439)

* message receiver/sender - fix null pointer error and ensure that receive/send link is recreated on a failure.

* Update version numbers for release (Azure#440)

* Update prefetch count for a receiver (Azure#441)

* Fix an issue of creating multiple sessions for $management & $cbs channel for a single connection and improve logging (Azure#443)

* Fix an issue of creating multiple sessions for $management & $cbs for a connection and improve logging

* Update version numbers for new release (Azure#444)

* Update spotbugs.xml report versions
serkantkaraca
serkantkaraca reviewed Jun 24, 2019
View reviewed changes
samples/DotNet/Rbac/AzureEventHubsSDK/Program.cs Outdated
{
Console.WriteLine("Choose an action:");
Console.WriteLine("[A] Authenticate via Managed Identity and send / receive.");
Console.WriteLine("[B] Authenticate via interactive logon and send / receive.");
Console.WriteLine("[C] Authenticate via client secret and send / receive.");
Console.WriteLine("[D] Authenticate via certificate and send / receive.");
Console.WriteLine("[E] Connect via data owner RBAC");
Console.WriteLine("[F] Connect via custom role RBAC");
Console.WriteLine("[G] Connect via ...");
Copy link
Member

@serkantkaraca serkantkaraca Jun 24, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these since single identity with data owner role will be used. #Resolved

@serkantkaraca
Copy link
Member

serkantkaraca commented Jun 24, 2019 •
edited
Loading 

  <add key="password" value="" />

Remove these not needed anymore. #Resolved

Refers to: samples/DotNet/Rbac/AzureEventHubsSDK/App.config:15 in 3684ee8. [](commit_id = 3684ee8, deletion_comment = False)

serkantkaraca
serkantkaraca approved these changes Jun 25, 2019
View reviewed changes
Copy link
Member

@serkantkaraca serkantkaraca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ShubhaVijayasarathy ShubhaVijayasarathy merged commit 742d8d8 into master Jun 25, 2019
@serkantkaraca serkantkaraca deleted the feature_eh_rbac branch July 3, 2019 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serkantkaraca serkantkaraca serkantkaraca approved these changes

@sjkwak sjkwak Awaiting requested review from sjkwak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShubhaVijayasarathy @serkantkaraca