-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ApplicationInsights] Enable AAD Auth #2217
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviau
previously requested changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that TelemetryConfiguration
is already used in the IOptions pattern, we can directly configure the credential on it. No need to go through FunctionsApplicationInsightsOptions
.
src/DotNetWorker.ApplicationInsights/FunctionsTelemetryModule.cs
Outdated
Show resolved
Hide resolved
...NetWorker.ApplicationInsights/Initializers/FunctionsApplicationInsightsOptionsInitializer.cs
Outdated
Show resolved
Hide resolved
This reverts commit 18288c8.
jviau
reviewed
Jan 19, 2024
src/DotNetWorker.ApplicationInsights/DotNetWorker.ApplicationInsights.csproj
Show resolved
Hide resolved
brettsam
approved these changes
Feb 27, 2024
andystaples
approved these changes
Feb 29, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling AAD Authentication in the ApplicationInsights worker package is achieved by configuring the APPLICATIONINSIGHTS_AUTHENTICATION_STRING. This configuration ensures a smooth Azure Active Directory Authentication experience across all ApplicationInsights pipelines.
I will update the doc after the release.
Pull request checklist
release_notes.md