Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ApplicationInsights] Enable AAD Auth #2217

Merged
merged 11 commits into from
Feb 29, 2024

Conversation

RohitRanjanMS
Copy link
Member

Enabling AAD Authentication in the ApplicationInsights worker package is achieved by configuring the APPLICATIONINSIGHTS_AUTHENTICATION_STRING. This configuration ensures a smooth Azure Active Directory Authentication experience across all ApplicationInsights pipelines.

  • Host AI Integration
  • Snapshot
  • Profiler
  • Java AI Agent (Released)
  • Node AI Agent (Inprogress)
  • Python AI Agent (Planned)
  • Isolated AI package (with this proposed change)

I will update the doc after the release.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

jviau
jviau previously requested changes Jan 17, 2024
Copy link
Contributor

@jviau jviau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that TelemetryConfiguration is already used in the IOptions pattern, we can directly configure the credential on it. No need to go through FunctionsApplicationInsightsOptions.

@RohitRanjanMS RohitRanjanMS requested a review from jviau January 18, 2024 21:36
@RohitRanjanMS RohitRanjanMS dismissed jviau’s stale review February 29, 2024 17:46

Comment addressed.

@RohitRanjanMS RohitRanjanMS merged commit 0052526 into main Feb 29, 2024
22 checks passed
@RohitRanjanMS RohitRanjanMS deleted the roranjan/EnableWorkerAIAADAuth branch February 29, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Application Insights work Managed Identity authentication
4 participants