Set IncludeEmptyEntriesInMessagePayload capability to true by default #2701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liliankasem
force-pushed
the
liliankasem/1096/always-send-empty-entries
branch
2 times, most recently
from
6216a84 to
7b57069
Compare
kshyju
reviewed
Sep 12, 2024
liliankasem
force-pushed
the
liliankasem/1096/always-send-empty-entries
branch
from
7b57069 to
13a9990
Compare
liliankasem
changed the title
liliankasem
changed the title
kshyju
approved these changes
Sep 13, 2024
fabiocav
pushed a commit
that referenced
this pull request
Oct 11, 2024
…#2701) * Set IncludeEmptyEntriesInMessagePayload to true by default * Update release notes
brettsam
pushed a commit
that referenced
this pull request
Oct 21, 2024
…#2701) * Set IncludeEmptyEntriesInMessagePayload to true by default * Update release notes
fabiocav
pushed a commit
that referenced
this pull request
Oct 21, 2024
…#2701) * Set IncludeEmptyEntriesInMessagePayload to true by default * Update release notes
fabiocav
pushed a commit
that referenced
this pull request
Oct 21, 2024
…#2701) * Set IncludeEmptyEntriesInMessagePayload to true by default * Update release notes
fabiocav
pushed a commit
that referenced
this pull request
Nov 11, 2024
…#2701) * Set IncludeEmptyEntriesInMessagePayload to true by default * Update release notes
fabiocav
pushed a commit
that referenced
this pull request
Nov 13, 2024
…#2701) * Set IncludeEmptyEntriesInMessagePayload to true by default * Update release notes
fabiocav
pushed a commit
that referenced
this pull request
Nov 13, 2024
…#2701) * Set IncludeEmptyEntriesInMessagePayload to true by default * Update release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #1096
Pull request checklist
release_notes.mdAdditional information
This makes a change so that the worker will by default send the
IncludeEmptyEntriesInPayloadcapability to the host. This means that empty entries will always be included in the message payload. This was initially created as a flag to avoid breaking users but there is no reason not to make this the permanent behaviour now as it's what would normally be expected.Original bug: #876