Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating service registration methods to ensure idempotency #2820

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Updating service registration methods to ensure idempotency #2820

merged 1 commit into from
Nov 11, 2024

Conversation

fabiocav
Copy link
Member

@fabiocav fabiocav commented Nov 4, 2024 •
edited
Loading

Updates to service registrations to ensure idempotency. With the recent updates, the changes in this PR will address unnecessary and invalid service registrations.

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@fabiocav fabiocav force-pushed the fabiocav/idempotentreg branch from ec3fe4b to 24a9a57 Compare November 4, 2024 05:41
@fabiocav fabiocav changed the title Uptading service registration methods to ensure idempotentency Updating service registration methods to ensure idempotency Nov 4, 2024
@fabiocav fabiocav force-pushed the fabiocav/idempotentreg branch 2 times, most recently from a2a3398 to a417c7d Compare November 11, 2024 06:37
@fabiocav fabiocav changed the base branch from feature/2.x to main November 11, 2024 06:38
@fabiocav fabiocav marked this pull request as ready for review November 11, 2024 06:45
@fabiocav fabiocav requested a review from jviau November 11, 2024 06:47
@fabiocav fabiocav force-pushed the fabiocav/idempotentreg branch from a417c7d to fdb8037 Compare November 11, 2024 17:30
@fabiocav fabiocav force-pushed the fabiocav/idempotentreg branch from fdb8037 to 21b7819 Compare November 11, 2024 17:33
@fabiocav fabiocav merged commit c6354f2 into main Nov 11, 2024
28 checks passed
@fabiocav fabiocav deleted the fabiocav/idempotentreg branch November 11, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettsam brettsam brettsam approved these changes

@jviau jviau Awaiting requested review from jviau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabiocav @brettsam @jviau