Update ContextReference & DefaultFromBodyConversionFeature to remove invocation cancellation token usage #2894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviau
reviewed
Dec 11, 2024
sdk/Sdk.Generators/FunctionExecutor/FunctionExecutorGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
...dk.Generators/FunctionMetadataProviderGenerator/FunctionMetadataProviderGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
...Sdk.Generators/FunctionMetadataProviderGenerator/FunctionMetadataProviderGenerator.Parser.cs
Outdated
Show resolved
Hide resolved
extensions/Worker.Extensions.Http/src/DefaultFromBodyConversionFeature.cs
Outdated
Show resolved
Hide resolved
extensions/Worker.Extensions.Http.AspNetCore/src/Coordinator/ContextReference.cs
Outdated
Show resolved
Hide resolved
extensions/Worker.Extensions.Http.AspNetCore/src/Coordinator/ContextReference.cs
Outdated
Show resolved
Hide resolved
liliankasem
force-pushed
the
liliankasem/invocation-ct
branch
from
627a808 to
70644de
Compare
liliankasem
changed the title
liliankasem
force-pushed
the
liliankasem/invocation-ct
branch
from
68a5025 to
ac93ee7
Compare
fabiocav
reviewed
Dec 12, 2024
extensions/Worker.Extensions.Http.AspNetCore/src/Coordinator/ContextReference.cs
Outdated
Show resolved
Hide resolved
extensions/Worker.Extensions.Http.AspNetCore/src/Coordinator/ContextReference.cs
Outdated
Show resolved
Hide resolved
liliankasem
changed the title
jviau
reviewed
Dec 16, 2024
extensions/Worker.Extensions.Http.AspNetCore/src/Coordinator/DefaultHttpCoordinator.cs
Outdated
Show resolved
Hide resolved
extensions/Worker.Extensions.Http/src/DefaultFromBodyConversionFeature.cs
Show resolved
Hide resolved
jviau
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Approving. If you have any formal explanation for why removing that token registration in ContextReference is a good change that would be helpful.
I know I suggested that change 😆 but it is still a significant behavior change, wondering what the impact of it really is.
I may have something in the design doc! I'll fill in any blanks and can update the PR desc with more info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #2417
Pull request checklist
release_notes.mdAdditional information
Based on the principal that our framework code will only ever propagate cancellation but never react to it, this PR updates
ContextReferenceto remove and reference or use of the invocation cancellation tokenDefaultFromBodyConversionFeatureto remove and reference or use of the invocation cancellation token