Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoggerFactory AutoFac resolution fails #1525

Closed
mathewc opened this issue May 19, 2017 · 0 comments
Closed

LoggerFactory AutoFac resolution fails #1525

mathewc opened this issue May 19, 2017 · 0 comments
Assignees
Milestone

Comments

@mathewc
Copy link
Member

mathewc commented May 19, 2017

Currently if you create an invalid host configuration (e.g. setting "functionTimeout": "00:50:00") it will cause ScriptHost initialization to fail early with a validation error. Requests to admin endpoints will subsequently fail, due to dependency injection resolution failures in this line of code. In this case the host instance is null, so this results in a null ref, and the ILoggerFactory fails to resolve. This causes AdminController creation to fail, and the portal cannot hit the status endpoint to show the validation error that the customer needs to see.

With these changes, the admin/host/status endpoint can correctly return the error:

{
  "state": "Error",
  "version": "1.0.0.0",
  "errors": [
    "Microsoft.Azure.WebJobs.Script: FunctionTimeout must be between 00:00:01 and 00:10:00."
  ]
}
@mathewc mathewc self-assigned this May 19, 2017
@paulbatum paulbatum added this to the May 2017 milestone May 19, 2017
@mathewc mathewc closed this as completed May 22, 2017
@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants