Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for updated command line args #726

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

shreyas-gopalakrishna
Copy link
Member

handling new command line arguments with functions- prefix

resolves #724

Host issue Azure/azure-functions-host#9504

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Copy link
Member

@kaibocai kaibocai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shreyas-gopalakrishna shreyas-gopalakrishna merged commit b037e95 into dev Sep 14, 2023
@shreyas-gopalakrishna shreyas-gopalakrishna deleted the shreyasg/commandline-args branch September 14, 2023 17:36
@kaibocai
Copy link
Member

Currently this will cause all the pipelines to fail, do we know when the latest host will be included in the pipeline core tools?

@shreyas-gopalakrishna
Copy link
Member Author

All languages are updating the command line args and host team is doing a release once this is done.
@kshyju can provide timelines

@kshyju
Copy link
Member

kshyju commented Sep 14, 2023

All languages are updating the command line args and host team is doing a release once this is done. @kshyju can provide timelines

The plan is to release the host changes along with the worker update in the same release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update java language worker to support handling new command line arguments with functions- prefix
4 participants