4.4.1 - Fixing NRE in IsWebJobsAttribute #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviau
approved these changes
Jul 30, 2024
| return attribute.AttributeType.Resolve().CustomAttributes.Any(a => a.AttributeType.FullName == "Microsoft.Azure.WebJobs.Description.BindingAttribute") | ||
| var attributeTypeDefinition = attribute.AttributeType?.Resolve(); | ||
|
|
||
| if (attributeTypeDefinition == null) |
There was a problem hiding this comment.
I am a fan of pattern matching, but no worries if you want to keep it as is:
if (attribute.AttributeType?.Resolve() is not { } attributeTypeDefinition)
{
return false;
}(may need to use actual type in place of { })
fabiocav
approved these changes
Jul 30, 2024
fabiocav
reviewed
Jul 30, 2024
Updated E2E test to cover the scenario which caused NRE. |
fabiocav
pushed a commit
that referenced
this pull request
Jul 31, 2024
… method (#655) * Adding null check to `IsWebJobsAttribute` extension method. * Fix method summary. * Updating E2E test to include a function with nullable parameter type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #641
attribute.AttributeType?.Resolve()inIsWebJobsAttributemethod, before calling other methods on the result of that.I also investigated the reason why the
Resolvemethod was returning null when using nullable parameter.The problem arises when the function parameter is nullable (e.g.,
string? id) in an in-process .NET 8.0 application. In such cases, theIsWebJobsAttributemethod is called forSystem.Runtime.CompilerServices.NullableAttribute, and theattribute.AttributeType.Resolve()expression returns null, leading to a NullReferenceException.This code is executed from
Microsoft.NET.Sdk.Functions.Generator, which we start from the .NET 6.0 output (relevant code here). This causes the .NET 6 version of theSystem.Runtimemodule (among others) to be loaded. TheNullableAttributeis not available in .NET 6, causing theResolvemethod to return null. Discussed this with the team and we agreed that returning false when Resolve returns null is good enough to address the issue.