Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add deprecated config-id parameter. #114

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Re-add deprecated config-id parameter. #114

merged 1 commit into from
Oct 28, 2019

Conversation

digimaun
Copy link
Member

@digimaun digimaun commented Oct 28, 2019

Resolves #113


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.

Thank you for contributing to the IoT extension!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • If introducing new functionality or modified behavior, are they backed by unit and integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all unit and integration tests passed locally? i.e. pytest -s <project root>/azext_iot/tests
  • Have static checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.

@digimaun digimaun requested a review from c-ryan-k October 28, 2019 19:09
@digimaun digimaun merged commit 716d154 into Azure:dev Oct 28, 2019
@digimaun digimaun deleted the readd_deprecated_configid branch October 28, 2019 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 0.8.4 breaks existing IoT Edge deployment command
2 participants