metrics: add support for more metric types

[akshaysngupta]

We are leveraging this project to get metrics for an azure resource onto k8s.
Adding support for more metric types to support our use case.

[jsturtevant]

@akshaysngupta the image build is failing. is make build working locally?

[akshaysngupta]

no actually, I am not able to go beyond on my machine. It gets stuck here during dep ensure

I was able to build the image using docker build -f .\Dockerfile -t <reg>/adapter:latest . and test it on k8s cluster.

[jsturtevant]

dep ensure is hanging because you are missing hg. Run apt-get install mercurial to get it then that should work.

I found the error related to the build issue and working on resolving it. Stay tuned.

[jsturtevant]

Can you rebase? It will pull in a change that will resolve the failed build.

[jsturtevant]

/azp run

[azure-pipelines]

No pipelines are associated with this pull request.

[jsturtevant]

@akshaysngupta it looks like the existing Queue Test is not returning the correct values and is getting zero for every request. I am guessing something isn't quite right in the logic to select the type of the Value.

What is the metric and type you are running in your local instance?

[akshaysngupta]

I am using metric of Average Type

[jsturtevant]

Could you share the ExternalMetric CRD you are using?

[akshaysngupta]

/azp run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 74 in repo Azure/azure-k8s-metrics-adapter

[jsturtevant]

/azp run

[azure-pipelines]

No pipelines are associated with this pull request.

[jsturtevant]

Thanks for the contribution! I left a few comments in the code. In addition it would be useful to add an e2e to cover the aggregation type. The easiest way to add this would probably use the already loaded Queue and an additional CRD to check a different aggregation type (maybe Max or Min?)

[jsturtevant]

/azp run

[azure-pipelines]

No pipelines are associated with this pull request.

[jsturtevant]

/azp run

[azure-pipelines]

No pipelines are associated with this pull request.

[jsturtevant]

Really close. Just a few extra checks in case there is bad data that comes back.

[jsturtevant]

/azp run