add origin application version to header #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y blob uri for ingestion
toshetah
suggested changes
Jan 27, 2019
data/src/main/java/com/microsoft/azure/kusto/data/ClientImpl.java
Outdated
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/ConnectionStringBuilder.java
Outdated
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/ConnectionStringBuilder.java
Outdated
Show resolved
Hide resolved
…y blob uri for ingestion
toshetah
suggested changes
Jan 27, 2019
data/src/main/java/com/microsoft/azure/kusto/data/ClientImpl.java
Outdated
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/ClientImpl.java
Outdated
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/ClientImpl.java
Outdated
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/ClientImpl.java
Outdated
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/ConnectionStringBuilder.java
Outdated
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/ConnectionStringBuilder.java
Outdated
Show resolved
Hide resolved
tamirkamara
requested changes
Jan 28, 2019
There was a problem hiding this comment.
A couple of general things:
- Please re-format the code (intellij action) of the files you changed
- I'd rethink how you handle the version reported to the traces because: (a) you let the user totally override the string reported which can produce traces that you could not understand later. (b) since client libs (even the spark connector) will depend on this lib but not package it internally, you can't infer one version from the other. In short, I think the user defined string should be concatenated to the base lib version.
data/src/main/java/com/microsoft/azure/kusto/data/ClientImpl.java
Outdated
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/ConnectionStringBuilder.java
Outdated
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/ConnectionStringBuilder.java
Outdated
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/ClientImpl.java
Outdated
Show resolved
Hide resolved
toshetah
reviewed
Jan 28, 2019
data/src/main/java/com/microsoft/azure/kusto/data/ClientImpl.java
Outdated
Show resolved
Hide resolved
tamirkamara
requested changes
Jan 31, 2019
data/src/main/java/com/microsoft/azure/kusto/data/ConnectionStringBuilder.java
Outdated
Show resolved
Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/ConnectionStringBuilder.java
Outdated
Show resolved
Hide resolved
toshetah
previously approved these changes
Jan 31, 2019
…add-originApplicationVersion
|
add origin application version to connectionStringBuilder to be added to the header (if not given will use the old way to retrieve java client version) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add origin application version to connectionStringBuilder to be added to the header (if not given will use the old way to retrieve java client version)