Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache-lastAuthenticationResult #70

Merged
merged 24 commits into from
Feb 20, 2019
Merged

cache-lastAuthenticationResult #70

merged 24 commits into from
Feb 20, 2019

Conversation

ohadbitt
Copy link
Collaborator

cache-lastAuthenticationResult

tamirkamara
tamirkamara requested changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@tamirkamara tamirkamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reformat the file please

data/src/main/java/com/microsoft/azure/kusto/data/AadAuthenticationHelper.java Outdated Show resolved Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/AadAuthenticationHelper.java Outdated Show resolved Hide resolved
@tamirkamara

This comment has been minimized.

Sign in to view
@ohbitton
cache access token
ff3ff99
@ohbitton
Merge branch 'dev' of https://github.com/Azure/azure-kusto-java into …
69cfee5 
…cache-lastAuthenticationResult

# Conflicts:
#	data/src/main/java/com/microsoft/azure/kusto/data/AadAuthenticationHelper.java
#	ingest/src/main/java/com/microsoft/azure/kusto/ingest/IngestClientImpl.java
@ohbitton
Merge branch 'dev' of https://github.com/Azure/azure-kusto-java into …
59967f0 
…cache-lastAuthenticationResult

# Conflicts:
#	data/src/main/java/com/microsoft/azure/kusto/data/AadAuthenticationHelper.java
#	ingest/src/main/java/com/microsoft/azure/kusto/ingest/IngestClientImpl.java
rabee333
rabee333 suggested changes Feb 20, 2019
View reviewed changes
Copy link
Contributor

@rabee333 rabee333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ohadbitt, I added some comments. Please review!

data/src/main/java/com/microsoft/azure/kusto/data/AadAuthenticationHelper.java Outdated Show resolved Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/AadAuthenticationHelper.java Outdated Show resolved Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/AadAuthenticationHelper.java Outdated Show resolved Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/AadAuthenticationHelper.java Show resolved Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/AadAuthenticationHelper.java Show resolved Hide resolved
data/src/main/java/com/microsoft/azure/kusto/data/ClientImpl.java Outdated Show resolved Hide resolved
data/src/test/java/com/microsoft/azure/kusto/data/AadAuthenticationHelperTest.java Show resolved Hide resolved
data/src/test/java/com/microsoft/azure/kusto/data/AadAuthenticationHelperTest.java Show resolved Hide resolved
rabee333
rabee333 previously approved these changes Feb 20, 2019
View reviewed changes
@ohadbitt ohadbitt merged commit 5ad1e6c into dev Feb 20, 2019
@ohadbitt ohadbitt deleted the cache-lastAuthenticationResult branch February 20, 2019 13:58
This was referenced Feb 20, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirkamara tamirkamara tamirkamara requested changes

@toshetah toshetah toshetah requested changes

@rabee333 rabee333 rabee333 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ohadbitt @tamirkamara @rabee333 @toshetah @ohbitton