Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IRedisCache WithSubnet(string subnetId) #305

Closed
TimLovellSmith opened this issue May 3, 2018 · 3 comments
Closed

IRedisCache WithSubnet(string subnetId) #305

TimLovellSmith opened this issue May 3, 2018 · 3 comments
Assignees
@hovsepm
Milestone
v1.13

Comments

@TimLovellSmith
Copy link
Member

It could be goodness for WithSubnet() to have an overload that takes (string subnetId) instead of (INetwork nw, string subnetName) just so that you aren't forced to fetch the subnet details in order to create the cache.
@hovsepm hovsepm self-assigned this May 3, 2018
@hovsepm
Copy link
Contributor

hovsepm commented May 3, 2018

Thanks for all 3 issues :) I'll try to fit the fixes in the next release - EOM.

@hovsepm
Copy link
Contributor

hovsepm commented May 10, 2018

fixed in Azure/azure-libraries-for-java#445

@hovsepm hovsepm added this to the v1.11 milestone May 10, 2018
@hovsepm hovsepm modified the milestones: v1.11, v1.12 May 31, 2018
@hovsepm hovsepm mentioned this issue Jun 22, 2018
Merged
@hovsepm hovsepm modified the milestones: v1.12, v1.13 Jun 22, 2018
hovsepm added a commit to Azure/azure-libraries-for-java that referenced this issue Jun 29, 2018
@hovsepm
Regenerated Redis with latest fixes. (#445)
b23aae4 
* Regenerated Redis with latest fixes.

* fix for Azure/azure-libraries-for-net#305

* Fix for Azure/azure-libraries-for-net#304

* fix for Azure/azure-libraries-for-net#303

* Fixed build break

* commit of the current dev state

* Added comments.

* Fixed stylecheck errors.

* fix of the fix

* Fixed the fix of the fix

* Fix the build break.

* Fix for PatchSchedule failures

* fixed style check breaks

* Fixed LinkedServers.

* Fixed build breaks.

* Re-recorded redis Azure test

* re-recorded Redis sample

* Fixed Beta since text.
@hovsepm
Copy link
Contributor

hovsepm commented Jul 16, 2018

Release 1.13 is out. Please upgrade your references.

@hovsepm hovsepm closed this as completed Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hovsepm hovsepm

Labels
None yet
Projects
None yet
Milestone
v1.13
Development

No branches or pull requests
2 participants
@TimLovellSmith @hovsepm