Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ExpressRouteGatewayBypass parameter to New-AzExpressRouteConnection and Set-AzExpressRouteConnection cmdlet #13375

Closed
wants to merge 8 commits into from

Conversation

sachethegde
Copy link
Contributor

Description

  1. Design review PR https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/747
  2. FastPath to vWan Firewall Hub - Adding ExpressRouteGatewayBypass flag parameter to New-AzExpressRouteConnection and Set-AzExpressRouteConnection cmdlet

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/Network/Network/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@sachethegde
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@markcowl
Copy link
Member

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@markcowl
Copy link
Member

/azp run azure-powershell - windows-powershell

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@VeryEarly VeryEarly self-assigned this Oct 31, 2020
@VeryEarly
Copy link
Contributor

your feature doesn't look rely on API 2020-07, please retarget your PR to master branch.
The network-july branch is currently for features related to API 2020-07 only.

Thanks

@sachethegde
Copy link
Contributor Author

@VeryEarly I am planning to make this feature part of 2020-07. Corresponding Swagger and PS design doc are here.
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/747
Azure/azure-rest-api-specs#10963
Please let me know if I am missing something.

@VeryEarly
Copy link
Contributor

close as backend implementation was not complete.

@VeryEarly VeryEarly closed this Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants