Fix PartnerServerName check in GetAzureSqlDatabaseReplicationLink.cs #13433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix check for PartnerServerName param check to look for string literal instead of value of variable.
isra-fel
reviewed
Nov 6, 2020
src/Sql/Sql/Replication/Cmdlet/GetAzureSqlDatabaseReplicationLink.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Yeming Liu <Yeming.Liu@microsoft.com>
isra-fel
approved these changes
Nov 6, 2020
|
/azp run azure-powershell - windows-powershell |
|
Azure Pipelines successfully started running 1 pipeline(s). |
greenms
pushed a commit
to greenms/azure-powershell
that referenced
this pull request
Nov 13, 2020
…zure#13433) * Fix PartnerServerName check Fix check for PartnerServerName param check to look for string literal instead of value of variable. * Update ChangeLog.md * Use nameof to avoid magic string Co-authored-by: Yeming Liu <Yeming.Liu@microsoft.com> Co-authored-by: Yeming Liu <Yeming.Liu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PartnerServerName (an optional parameter) is currently checking invocation by examining the value of the variable PartnerServerName instead of string literal "PartnerServerName". When invoking the cmdlet, it yields unexpected behavior as check never passes and it invokes as if PartnerServerName parameter was not passed.
Added double quotes around PartnerServerName to check for key.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added