Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RecordType in examples 3 and 4 #13447

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Conversation

luisarnauth
Copy link
Contributor

Description

Both examples 3 and 4 mention a RecordType of AAAA but should mention CNAME and MX respectively

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

Both examples 3 and 4 mention a RecordType of AAAA but should mention CNAME and MX respectively
@isra-fel
Copy link
Member

isra-fel commented Nov 9, 2020

/azp run azure-powershell - windows-powershell

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for you contribution 👍

@isra-fel isra-fel self-assigned this Nov 9, 2020
@isra-fel isra-fel merged commit 916643b into master Nov 9, 2020
@isra-fel isra-fel deleted the luisarnauth-patch-1-1 branch November 9, 2020 02:35
greenms pushed a commit to greenms/azure-powershell that referenced this pull request Nov 13, 2020
Both examples 3 and 4 mention a RecordType of AAAA but should mention CNAME and MX respectively
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants