Az.StackHCI Cmdlet registration changes for GA #13454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made changes to registration script to register the GA version of On-Premises Azure Stack HCI with Azure. - Supports registering with user provided certificate thumbprint. - Supports On-Premises Azure Stack HCI OS changes to use independent certificate on cluster nodes. - Cleans up resource group during unregistration. - Improves registration output and logging. Breaks the public preview registration of On-Premises Azure Stack HCI with Azure. - To register public preview On-Premises Azure Stack HCi with Azure, use 0.3.1 version of Az.StackHCI.
Added Test-AzStackHCIConnection Cmdlet and generated help files
ghost
added
the
|
Thank you for your contribution dineshreddy007! We will review the pull request and get back to you soon. |
dineshreddy007
changed the title
Using UseDeviceAuthentication as paramater name instead of UseDeviceLogin. Checking existing resource location against given location.
isra-fel
added
Cmdlet Review Complete
needs-review
and removed
Cmdlet Review Required ⚠️
labels
isra-fel
requested changes
Nov 10, 2020
| # Test-AzStackHCIConnection | ||
|
|
||
| ## SYNOPSIS | ||
|
|
There was a problem hiding this comment.
Filled in synopsis now.
| --- | ||
| external help file: Az.StackHCI-help.xml | ||
| Module Name: Az.StackHCI | ||
| online version: |
There was a problem hiding this comment.
Use
Suggested change
| online version: | |
| online version: https://docs.microsoft.com/powershell/module/az.stackhci/test-azstackhciconnection |
There was a problem hiding this comment.
updated online version
src/StackHCI/ChangeLog.md
Outdated
| - Supports On-Premises Azure Stack HCI OS changes to use independent certificate on cluster nodes. | ||
| - Cleans up resource group during unregistration. | ||
| - Improves registration output and logging. | ||
| * Breaks the public preview registration of On-Premises Azure Stack HCI with Azure. |
There was a problem hiding this comment.
More explicit
Suggested change
| * Breaks the public preview registration of On-Premises Azure Stack HCI with Azure. | |
| * [Breaking Change] Breaks the public preview registration of On-Premises Azure Stack HCI with Azure. |
There was a problem hiding this comment.
Mentioning explicitly now.
Added synopsis and corrected changelog as per review suggestion
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
greenms
pushed a commit
to greenms/azure-powershell
that referenced
this pull request
Nov 13, 2020
* Registration changes to support GA On-Premises Stack HCI Made changes to registration script to register the GA version of On-Premises Azure Stack HCI with Azure. - Supports registering with user provided certificate thumbprint. - Supports On-Premises Azure Stack HCI OS changes to use independent certificate on cluster nodes. - Cleans up resource group during unregistration. - Improves registration output and logging. Breaks the public preview registration of On-Premises Azure Stack HCI with Azure. - To register public preview On-Premises Azure Stack HCi with Azure, use 0.3.1 version of Az.StackHCI. * Added Test-AzStackHCIConnection Cmdlet Added Test-AzStackHCIConnection Cmdlet and generated help files * Using UseDeviceAuthentication param name Using UseDeviceAuthentication as paramater name instead of UseDeviceLogin. Checking existing resource location against given location. * Added synopsis and corrected changelog Added synopsis and corrected changelog as per review suggestion * try to fix static analysis issue Co-authored-by: Dinesh Reddy Gottam <digot@microsoft.com> Co-authored-by: Yeming Liu <Yeming.Liu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Design review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/773
Made changes to registration script to register the GA version of On-Premises Azure Stack HCI with Azure.
Breaks the public preview registration of On-Premises Azure Stack HCI with Azure.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added