Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Aks]Fix the issue of service principal. #13458

Merged
merged 1 commit into from
Nov 9, 2020
Merged

[Aks]Fix the issue of service principal. #13458

merged 1 commit into from
Nov 9, 2020

Conversation

wyunchi-ms
Copy link
Contributor

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@isra-fel isra-fel self-assigned this Nov 9, 2020
@wyunchi-ms
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

isra-fel
isra-fel reviewed Nov 9, 2020
View reviewed changes
src/Aks/Aks.Test/ScenarioTests/KubernetesTests.ps1
$location = "eastus"

$ServicePrincipalId = '618a2a3a-9d44-415a-b0ce-9729253a4ba9'
$Secret = '5E41A57vC_ODdiFb5ji-a9~C~Mp3gKt7D~'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true secret? Has the secret been revoked?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The service principal has been removed.

@isra-fel isra-fel merged commit fd71499 into master Nov 9, 2020
@isra-fel isra-fel deleted the wyunchi/fix/aks-service-principal branch November 9, 2020 05:44
@wyunchi-ms wyunchi-ms mentioned this pull request Nov 12, 2020
Closed
greenms pushed a commit to greenms/azure-powershell that referenced this pull request Nov 13, 2020
@wyunchi-ms @greenms
Fix the issue of service principal. (Azure#13458)
6faa867 
Co-authored-by: wyunchi-ms <yunwang@microsoft.com>
@wyunchi-ms wyunchi-ms mentioned this pull request Dec 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

Assignees

@isra-fel isra-fel

Labels
needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wyunchi-ms @isra-fel @azuresdkci