Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Cluster commands for EventHub cluster without tags and updated help text for AzEventHubGeoDRConfiguration #13460

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Fixed Cluster commands for EventHub cluster without tags and updated help text for AzEventHubGeoDRConfiguration #13460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/EventHub/EventHub.Test/ScenarioTests/ClusterTest.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ Tests Eventhub Cluster operations.

function ClusterTest
{
# Setup
# Setup
$location = "southcentralus"
$clusterName = getAssetName "Eventhub-Cluster-"
$resourceGroupName = getAssetName "RSG-Cluster"

Write-Debug " Create resource group"
Write-Debug " Create resource group"
Write-Debug " Resource Group Name : $resourceGroupName"
$ResultResourceGroup = New-AzResourceGroup -Name $resourceGroupName -Location $location -Force

Expand Down
2 changes: 2 additions & 0 deletions src/EventHub/EventHub/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
- Additional information about change #1
-->
## Upcoming Release
* Fixed Cluster commands for EventHub cluster without tags
* updated help text for PartnerNamespace of AzEventHubGeoDRConfiguration commands

## Version 1.7.0
* Added optional switch parameter `TrustedServiceAccessEnabled` to `Set-AzEventHubNetworkRuleSet` cmdlet
Expand Down
2 changes: 1 addition & 1 deletion src/EventHub/EventHub/Cmdlets/DRConfig/NewAzureEventHubGeoDRConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public class NewAzureRmEventHubGeoDRConfiguration : AzureEventHubsCmdletBase
[ValidateNotNullOrEmpty]
public string Name { get; set; }

[Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, Position = 3, HelpMessage = "DR Configuration PartnerNamespace")]
[Parameter(Mandatory = true, ValueFromPipelineByPropertyName = true, Position = 3, HelpMessage = "DR Configuration PartnerNamespace ARM ID")]
[ValidateNotNullOrEmpty]
public string PartnerNamespace { get; set; }

Expand Down
2 changes: 1 addition & 1 deletion src/EventHub/EventHub/Models/PSEventHubDRConfigurationAttributes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public PSEventHubDRConfigurationAttributes(ArmDisasterRecovery drResource)
public ProvisioningStateDR? ProvisioningState { get; set; }

/// <summary>
/// Gets or sets a value that indicates partner namespace
/// Gets or sets a value that indicates partner namespace ARM ID
/// </summary>
public string PartnerNamespace { get; set; }

Expand Down
2 changes: 1 addition & 1 deletion src/EventHub/EventHub/Models/PSEventHubsClusterAttributes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public PSEventHubClusterAttributes(Cluster cluster)
UpdatedAt = cluster.UpdatedAt;
Status = cluster.Status;
Sku = new PSEventHubsClusterSkuAttributes(cluster.Sku);
if (cluster.Tags.Count > 0)
if (cluster.Tags != null)
{
Tags = new Dictionary<string, string>(cluster.Tags);
}
Expand Down
2 changes: 1 addition & 1 deletion src/EventHub/EventHub/help/New-AzEventHubGeoDRConfiguration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ Accept wildcard characters: False
```

### -PartnerNamespace
DR Configuration PartnerNamespace
DR Configuration PartnerNamespace ARM ID

```yaml
Type: System.String
Expand Down