Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erich/fix write object error #13466

Merged
merged 3 commits into from
Nov 10, 2020
Merged

Erich/fix write object error #13466

merged 3 commits into from
Nov 10, 2020

Conversation

erich-wang
Copy link
Member

@erich-wang erich-wang commented Nov 9, 2020 •
edited
Loading

Description

fix issue #13419

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@erich-wang erich-wang added this to the S178 (2020-11-17) milestone Nov 9, 2020
isra-fel
isra-fel approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erich-wang
Copy link
Member Author

Force merge it as it is transient test time out on Mac OS

@erich-wang erich-wang merged commit e8fd3c6 into Azure:master Nov 10, 2020
greenms pushed a commit to greenms/azure-powershell that referenced this pull request Nov 13, 2020
@erich-wang @greenms
Erich/fix write object error (Azure#13466)
00abbcb 
* fix Write-xxx in worker thread

* add change log
@erich-wang erich-wang linked an issue Nov 16, 2020 that may be closed by this pull request
Connect-AzAccount v2.1.2 errors with WriteObject and WriteError method error #13419
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

Assignees
No one assigned
Labels
Waiting for CI :shipit:
Projects
None yet
Milestone
S178 (2020-11-17)
Development

Successfully merging this pull request may close these issues.

Connect-AzAccount v2.1.2 errors with WriteObject and WriteError method error
3 participants
@erich-wang @isra-fel @azuresdkci