Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Az.Tools.Predictor refactor and performance improvement. #13669

Merged
merged 15 commits into from
Dec 15, 2020

Commits on Nov 30, 2020

  1. Configuration menu
    Copy the full SHA
    ecab80a View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2020

  1. Refactor the code

    - Improve the comment and its format.
    - Create a concret class type to replace Tuple and ValueTuple.
    - Verify method parameter values.
    kceiw committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    ae6f18e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4856a25 View commit details
    Browse the repository at this point in the history
  3. Improve the telemetry.

    - Combine the error telemetry event with the non-error one.
    - Collect if the http request is canceled when we send http request.
    kceiw committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    2507f94 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2d88593 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2020

  1. Transform and send telemetry in a thread pool.

    - Refactor the telemetry and use a class for the collected data in each
      telemetry event.
    - Now we only get basic information and push them to the data flow.
    - A thread from thread pool handles the data, transform them, and send
      it.
    kceiw committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    df2db75 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2020

  1. Fix the SuggestionSource and test.

    - Updated the test after the refactor.
    - Add more test cases.
    - We don't set SuggestionSource on the suggestion in some cases. This is
      revealed in the unit tests. They're fixed.
    kceiw committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    70b8720 View commit details
    Browse the repository at this point in the history
  2. Avoid duplicate extraction of user input.

    - We have two CommandLinePredictor in AzurePredictorService. The
      CommandLinePredictor needs to extract from the user input the command
      name, parameter set etc. It's duplicate if we do that in both
      CommandLinePredictor. Move that extraction to AzurePredictorService
      and the CommandLinePredictor will not need to do it.
    kceiw committed Dec 3, 2020
    Configuration menu
    Copy the full SHA
    c4d7654 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0fc0ca2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b2a8867 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0711921 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2020

  1. Configuration menu
    Copy the full SHA
    84fa5a6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d4f0699 View commit details
    Browse the repository at this point in the history
  3. Improve the perf in GetSuggestion.

    - Remove the string manipulation.
    - Pre-allocate the collections for the result.
    - Remove invariant check in "readonly" properties.
    kceiw committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    ed6cd4e View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2020

  1. Configuration menu
    Copy the full SHA
    a64b659 View commit details
    Browse the repository at this point in the history