-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Az.Tools.Predictor refactor and performance improvement. #13669
Merged
Merged
Commits on Nov 30, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ecab80a - Browse repository at this point
Copy the full SHA ecab80aView commit details
Commits on Dec 1, 2020
-
- Improve the comment and its format. - Create a concret class type to replace Tuple and ValueTuple. - Verify method parameter values.
Configuration menu - View commit details
-
Copy full SHA for ae6f18e - Browse repository at this point
Copy the full SHA ae6f18eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4856a25 - Browse repository at this point
Copy the full SHA 4856a25View commit details -
- Combine the error telemetry event with the non-error one. - Collect if the http request is canceled when we send http request.
Configuration menu - View commit details
-
Copy full SHA for 2507f94 - Browse repository at this point
Copy the full SHA 2507f94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d88593 - Browse repository at this point
Copy the full SHA 2d88593View commit details
Commits on Dec 2, 2020
-
Transform and send telemetry in a thread pool.
- Refactor the telemetry and use a class for the collected data in each telemetry event. - Now we only get basic information and push them to the data flow. - A thread from thread pool handles the data, transform them, and send it.
Configuration menu - View commit details
-
Copy full SHA for df2db75 - Browse repository at this point
Copy the full SHA df2db75View commit details
Commits on Dec 3, 2020
-
Fix the SuggestionSource and test.
- Updated the test after the refactor. - Add more test cases. - We don't set SuggestionSource on the suggestion in some cases. This is revealed in the unit tests. They're fixed.
Configuration menu - View commit details
-
Copy full SHA for 70b8720 - Browse repository at this point
Copy the full SHA 70b8720View commit details -
Avoid duplicate extraction of user input.
- We have two CommandLinePredictor in AzurePredictorService. The CommandLinePredictor needs to extract from the user input the command name, parameter set etc. It's duplicate if we do that in both CommandLinePredictor. Move that extraction to AzurePredictorService and the CommandLinePredictor will not need to do it.
Configuration menu - View commit details
-
Copy full SHA for c4d7654 - Browse repository at this point
Copy the full SHA c4d7654View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fc0ca2 - Browse repository at this point
Copy the full SHA 0fc0ca2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2a8867 - Browse repository at this point
Copy the full SHA b2a8867View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0711921 - Browse repository at this point
Copy the full SHA 0711921View commit details
Commits on Dec 4, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 84fa5a6 - Browse repository at this point
Copy the full SHA 84fa5a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4f0699 - Browse repository at this point
Copy the full SHA d4f0699View commit details -
Improve the perf in GetSuggestion.
- Remove the string manipulation. - Pre-allocate the collections for the result. - Remove invariant check in "readonly" properties.
Configuration menu - View commit details
-
Copy full SHA for ed6cd4e - Browse repository at this point
Copy the full SHA ed6cd4eView commit details
Commits on Dec 8, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a64b659 - Browse repository at this point
Copy the full SHA a64b659View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.