Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for maintenance configuration for SQL DB #13926

Merged
merged 4 commits into from
Jan 14, 2021
Merged

Adding support for maintenance configuration for SQL DB #13926

merged 4 commits into from
Jan 14, 2021

Conversation

hotsnr
Copy link
Contributor

@hotsnr hotsnr commented Jan 11, 2021

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@hotsnr hotsnr marked this pull request as ready for review January 13, 2021 21:55
Copy link
Contributor

@msJinLei msJinLei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the description to the https://github.com/hotsnr/azure-powershell/blob/rokhot/sqldb-maintenance/src/Sql/Sql/ChangeLog.md
Please note your description item should the first time under upcoming release.

@hotsnr
Copy link
Contributor Author

hotsnr commented Jan 14, 2021

Please add the description to the https://github.com/hotsnr/azure-powershell/blob/rokhot/sqldb-maintenance/src/Sql/Sql/ChangeLog.md
Please note your description item should the first time under upcoming release.

I edited that file, do you mean that it should be the first line in 'Upcoming release' section? I didn't see such requirement in the guide.

Move the new item to the top of upcoming release to avoid merge issue when release branch merge back.
@msJinLei
Copy link
Contributor

Please add the description to the https://github.com/hotsnr/azure-powershell/blob/rokhot/sqldb-maintenance/src/Sql/Sql/ChangeLog.md
Please note your description item should the first time under upcoming release.

I edited that file, do you mean that it should be the first line in 'Upcoming release' section? I didn't see such requirement in the guide.

When we are in the process of the release, new PR should the put its description item to the top of the upcoming release to avoid merge issue when release branch is merged back if there are other description items under the upcoming release.

@msJinLei msJinLei merged commit 1362838 into Azure:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants