-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix top value when top is not provided #14051
Conversation
@@ -19,6 +19,9 @@ | |||
--> | |||
## Upcoming Release | |||
|
|||
## Version 1.4.1 | |||
* Undo bug with version 1.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't descriptive enough. Say something about reverting a change in 1.4.0 to pull in all pages by default. Default page size is now 'X' for Get-AzPolicyState
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pagination is not yet supported in powershell it is to be implemented, not sure how to word this without using word page.
when a user does not provide top we return 1000 rows, once paging is supported here we will send in 1000 rows plus a nextLink.
the description for this release was support pagination, do i need to instead say "unsupport pagination"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let Liz/Kemley word it :-) However, you definitely need to mention which cmdlet this affects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add "Retracting changes made in powershell that increased request row limit. Removed incorrect statement of supporting paging" as suggested by Kemley
0303616
to
c77e2c6
Compare
@najagasi Please do not add new version to changelog and just put new items under upcoming release |
Description
This PR is to revert the changes that are made in this PR dafc0d9#diff-5fcd32ad9abc940415b096a7b99c3f3882e4c27dd7806430212796a347c94952
its causing requests made to the RP with top=2147483647 when no $top is requested.
Checklist
CONTRIBUTING.md
ChangeLog.md
file(s) has been updated:ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header -- no new version header should be added