Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix top value when top is not provided #14051

Merged
merged 3 commits into from
Jan 29, 2021
Merged

Conversation

najagasi
Copy link
Contributor

Description

This PR is to revert the changes that are made in this PR dafc0d9#diff-5fcd32ad9abc940415b096a7b99c3f3882e4c27dd7806430212796a347c94952
its causing requests made to the RP with top=2147483647 when no $top is requested.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@@ -19,6 +19,9 @@
-->
## Upcoming Release

## Version 1.4.1
* Undo bug with version 1.4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't descriptive enough. Say something about reverting a change in 1.4.0 to pull in all pages by default. Default page size is now 'X' for Get-AzPolicyState

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pagination is not yet supported in powershell it is to be implemented, not sure how to word this without using word page.
when a user does not provide top we return 1000 rows, once paging is supported here we will send in 1000 rows plus a nextLink.
the description for this release was support pagination, do i need to instead say "unsupport pagination"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let Liz/Kemley word it :-) However, you definitely need to mention which cmdlet this affects

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add "Retracting changes made in powershell that increased request row limit. Removed incorrect statement of supporting paging" as suggested by Kemley

@msJinLei
Copy link
Contributor

@najagasi Please do not add new version to changelog and just put new items under upcoming release

@msJinLei msJinLei merged commit 1695bb0 into Azure:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants