Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtual Wan P2S MultiPool feature changes #17032

Merged
merged 20 commits into from
Apr 27, 2022
Merged

Virtual Wan P2S MultiPool feature changes #17032

merged 20 commits into from
Apr 27, 2022

Conversation

Nilambari
Copy link
Member

@Nilambari Nilambari commented Feb 7, 2022 •
edited
Loading

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:

@Nilambari Nilambari changed the title Virtual Wan P2S MultiPool feature changes Draft: Virtual Wan P2S MultiPool feature changes Feb 7, 2022
@VeryEarly VeryEarly marked this pull request as draft February 8, 2022 07:58
@Nilambari Nilambari changed the title Draft: Virtual Wan P2S MultiPool feature changes Virtual Wan P2S MultiPool feature changes Feb 22, 2022
@Nilambari Nilambari marked this pull request as ready for review February 22, 2022 23:54
@BethanyZhou
Copy link
Contributor

CI failed: The type or namespace name 'IConfigurationPolicyGroupsOperations' could not be found (are you missing a using directive or an assembly reference?) Please have a look.

BethanyZhou
BethanyZhou reviewed Mar 1, 2022
View reviewed changes
src/Network/Network.Test/ScenarioTests/CortexTests.ps1 Outdated
@@ -746,17 +760,17 @@ function Test-CortexExpressRouteCRUD
Assert-AreEqual $vpnServerConfig1.Id $P2SVpnGateway.VpnServerConfiguration.Id
Assert-AreEqual "Succeeded" $P2SVpnGateway.ProvisioningState
Assert-AreEqual 1 @($P2SVpnGateway.CustomDnsServers).Count
Assert-AreEqual "7.7.7.7" $P2SVpnGateway.CustomDnsServers[0]
Assert-AreEqual "7.7.7.7" $P2SVpnGateway.CustomDnsServers[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Assert-AreEqual "7.7.7.7" $P2SVpnGateway.CustomDnsServers[0]
Assert-AreEqual "7.7.7.7" $P2SVpnGateway.CustomDnsServers[0]

src/Network/Network.Test/ScenarioTests/CortexTests.ps1 Outdated
Comment on lines 771 to 773
$job = Reset-AzP2sVpnGateway -P2SVpnGateway $P2SVpnGateway -AsJob
$job | Wait-Job
$actual = $job | Receive-Job
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct indents.

src/Network/Network/Az.Network.psd1 Show resolved Hide resolved
@BethanyZhou BethanyZhou self-assigned this Mar 1, 2022
@isra-fel isra-fel assigned isra-fel and unassigned BethanyZhou Apr 2, 2022
@Nilambari
Copy link
Member Author

@isra-fel Incorporate review comment. Please take a look.

@Nilambari
Copy link
Member Author

CI failed: The type or namespace name 'IConfigurationPolicyGroupsOperations' could not be found (are you missing a using directive or an assembly reference?) Please have a look.

Waiting for latest network SDK generation.

@isra-fel
Copy link
Member

Generally looks good. Please regenerate help documents and resolve the conflicts.

@Nilambari
Copy link
Member Author

Generally looks good. Please regenerate help documents and resolve the conflicts.

Done. @isra-fel Please take a look. Thanks!

isra-fel
isra-fel requested changes Apr 27, 2022
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file src/Network/Network/help/Az.Network.md is supposed to be updated when introducing new cmdlets.
Please make sure to use -RefreshModulePage when regenerating helps, see https://github.com/Azure/azure-powershell/blob/main/documentation/development-docs/help-generation.md#updating-all-markdown-files-in-a-module

@nilambarideshpande
Copy link

This file src/Network/Network/help/Az.Network.md is supposed to be updated when introducing new cmdlets.
Please make sure to use -RefreshModulePage when regenerating helps, see https://github.com/Azure/azure-powershell/blob/main/documentation/development-docs/help-generation.md#updating-all-markdown-files-in-a-module

Let me update it. Thanks.

@Nilambari
Copy link
Member Author

Let me update it. Thanks.

Incorporated review comments & included latest test recording as well. @isra-fel Please take a look and help approve this PR. Thanks!

@Nilambari Nilambari changed the base branch from network-2021-08-01 to main April 27, 2022 07:49
@isra-fel
Copy link
Member

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@isra-fel isra-fel merged commit 64a914b into Azure:main Apr 27, 2022
@isra-fel isra-fel mentioned this pull request May 26, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethanyZhou BethanyZhou BethanyZhou left review comments

@isra-fel isra-fel isra-fel approved these changes

@MikhailTryakhov MikhailTryakhov Awaiting requested review from MikhailTryakhov

Assignees

@isra-fel isra-fel

Labels
Cmdlet Review Complete Waiting for CI :shipit:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nilambari @BethanyZhou @isra-fel @nilambarideshpande