{HDInsight}Hdi migrate Microsoft.Azure.Graph to MicrosoftGraph #17219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aim-for-better
force-pushed
the
HdiMigrate2MSGraph
branch
from
403571c
to
669d80f
Compare
isra-fel
requested changes
Feb 28, 2022
src/HDInsight/HDInsight/ChangeLog.md
Outdated
| @@ -18,6 +18,7 @@ | |||
| - Additional information about change #1 | |||
| --> | |||
| ## Upcoming Release | |||
| This release migrates Microsoft.Azure.Graph SDK to MicrsoftGraph SDK, there is not customer impact. | |||
There was a problem hiding this comment.
This migration might have impact on customers because the permission required to call AAD graph and MS graph APIs are different.
Suggested change
| This release migrates Microsoft.Azure.Graph SDK to MicrsoftGraph SDK, there is not customer impact. | |
| This release migrates Microsoft.Azure.Graph SDK to MicrsoftGraph SDK. |
| try | ||
| { | ||
| sp = graphClient.ServicePrincipals.Get(ObjectId.ToString()); | ||
| sp = graphClient.ServicePrincipals.GetServicePrincipalWithHttpMessagesAsync(ObjectId.ToString()).Result.Body;//graphClient.ServicePrincipals.Get(ObjectId.ToString()); |
There was a problem hiding this comment.
You can use this extension method to simplify code: https://github.com/Azure/azure-powershell-common/blob/main/src/Graph.Rbac/MicrosoftGraph/Version1_0/Applications/ServicePrincipalsOperationsExtensions.cs#L210
Suggested change
| sp = graphClient.ServicePrincipals.GetServicePrincipalWithHttpMessagesAsync(ObjectId.ToString()).Result.Body;//graphClient.ServicePrincipals.Get(ObjectId.ToString()); | |
| sp = graphClient.ServicePrincipals.GetServicePrincipal(ObjectId.ToString()); |
| { | ||
| string errorMessage = e.Message + ". Please specify Application Id explicitly by providing ApplicationId parameter and retry."; | ||
| throw new Microsoft.Azure.Graph.RBAC.Version1_6.Models.GraphErrorException(errorMessage); | ||
| throw new Exception(errorMessage); |
There was a problem hiding this comment.
Please use AzPSArgumentException so we can get detailed telemetry data.
added 2 commits
March 1, 2022 10:49
…powershell into HdiMigrate2MSGraph
|
Hi @isra-fel Thanks for your review, I have updated the PR. |
Added |
aim-for-better
commented
Mar 1, 2022
| @@ -100,6 +100,10 @@ New-AzHDInsightCluster [-Location] <String> [-ResourceGroupName] <String> [-Clus | |||
| ## DESCRIPTION | |||
| The New-AzHDInsightCluster creates an Azure HDInsight cluster by using the specified parameters or by using a configuration object that is created by using the New-AzHDInsightClusterConfig cmdlet. | |||
|
|
|||
| The cmdlet may call below Microsoft Graph API according to input parameters: | |||
|
|
|||
| - GET /servicePrincipals/{id} | |||
There was a problem hiding this comment.
Added in the help doc
isra-fel
approved these changes
Mar 1, 2022
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate Microsoft.Azure.Graph to MicrosoftGraph
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added