Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powershell changes for supporting ExpressRoutePort authorization #17392

Merged
merged 11 commits into from
Apr 12, 2022

Conversation

utbarn-ms
Copy link
Member

@utbarn-ms utbarn-ms commented Mar 7, 2022

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:

@utbarn-ms utbarn-ms changed the title powershell changes for er ports authorization draft: powershell changes for er ports authorization Mar 7, 2022
@utbarn-ms utbarn-ms changed the title draft: powershell changes for er ports authorization Powershell changes for supporting ExpressRoutePort authorization Mar 15, 2022
@BethanyZhou
Copy link
Contributor

Some issues are reported,

Common\NetworkResourceManagerProfile.cs(779,72): error CS0234: The type or namespace name 'ExpressRoutePortAuthorization' does not exist in the namespace 'Microsoft.Azure.Management.Network.Models' (are you missing an assembly reference?) [D:\a\1\s\src\Network\Network\Network.csproj] [D:\a\1\s\build.proj]
Common\NetworkResourceManagerProfile.cs(784,35): error CS0234: The type or namespace name 'ExpressRoutePortAuthorization' does not exist in the namespace 'Microsoft.Azure.Management.Network.Models' (are you missing an assembly reference?) [D:\a\1\s\src\Network\Network\Network.csproj] [D:\a\1\s\build.proj]
ExpressRoutePort\Authorization\AddAzureExpressRoutePortAuthorizationCommand.cs(49,60): error CS1061: 'INetworkManagementClient' does not contain a definition for 'ExpressRoutePortAuthorizations' and no accessible extension method 'ExpressRoutePortAuthorizations' accepting a first argument of type 'INetworkManagementClient' could be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\src\Network\Network\Network.csproj] [D:\a\1\s\build.proj]
ExpressRoutePort\Authorization\AddAzureExpressRoutePortAuthorizationCommand.cs(69,51): error CS0234: The type or namespace name 'ExpressRoutePortAuthorization' does not exist in the namespace 'Microsoft.Azure.Management.Network.Models' (are you missing an assembly reference?) [D:\a\1\s\src\Network\Network\Network.csproj] [D:\a\1\s\build.proj]
ExpressRoutePort\Authorization\AddAzureExpressRoutePortAuthorizationCommand.cs(73,95): error CS1061: 'INetworkManagementClient' does not contain a definition for 'ExpressRoutePortAuthorizations' and no accessible extension method 'ExpressRoutePortAuthorizations' accepting a first argument of type 'INetworkManagementClient' could be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\src\Network\Network\Network.csproj] [D:\a\1\s\build.proj]
ExpressRoutePort\Authorization\GetAzureExpressRoutePortAuthorizationCommand.cs(42,99): error CS1061: 'INetworkManagementClient' does not contain a definition for 'ExpressRoutePortAuthorizations' and no accessible extension method 'ExpressRoutePortAuthorizations' accepting a first argument of type 'INetworkManagementClient' could be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\src\Network\Network\Network.csproj] [D:\a\1\s\build.proj]
ExpressRoutePort\Authorization\GetAzureExpressRoutePortAuthorizationCommand.cs(49,101): error CS1061: 'INetworkManagementClient' does not contain a definition for 'ExpressRoutePortAuthorizations' and no accessible extension method 'ExpressRoutePortAuthorizations' accepting a first argument of type 'INetworkManagementClient' could be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\src\Network\Network\Network.csproj] [D:\a\1\s\build.proj]
ExpressRoutePort\Authorization\RemoveAzureExpressRoutePortAuthorizationCommand.cs(46,56): error CS1061: 'INetworkManagementClient' does not contain a definition for 'ExpressRoutePortAuthorizations' and no accessible extension method 'ExpressRoutePortAuthorizations' accepting a first argument of type 'INetworkManagementClient' could be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\src\Network\Network\Network.csproj] [D:\a\1\s\build.proj]

could you check your assembly?

@utbarn-ms
Copy link
Member Author

Some issues are reported,

Common\NetworkResourceManagerProfile.cs(779,72): error CS0234: The type or namespace name 'ExpressRoutePortAuthorization' does not exist in the namespace 'Microsoft.Azure.Management.Network.Models' (are you missing an assembly reference?) [D:\a\1\s\src\Network\Network\Network.csproj] [D:\a\1\s\build.proj]
Common\NetworkResourceManagerProfile.cs(784,35): error CS0234: The type or namespace name 'ExpressRoutePortAuthorization' does not exist in the namespace 'Microsoft.Azure.Management.Network.Models' (are you missing an assembly reference?) [D:\a\1\s\src\Network\Network\Network.csproj] [D:\a\1\s\build.proj]
ExpressRoutePort\Authorization\AddAzureExpressRoutePortAuthorizationCommand.cs(49,60): error CS1061: 'INetworkManagementClient' does not contain a definition for 'ExpressRoutePortAuthorizations' and no accessible extension method 'ExpressRoutePortAuthorizations' accepting a first argument of type 'INetworkManagementClient' could be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\src\Network\Network\Network.csproj] [D:\a\1\s\build.proj]
ExpressRoutePort\Authorization\AddAzureExpressRoutePortAuthorizationCommand.cs(69,51): error CS0234: The type or namespace name 'ExpressRoutePortAuthorization' does not exist in the namespace 'Microsoft.Azure.Management.Network.Models' (are you missing an assembly reference?) [D:\a\1\s\src\Network\Network\Network.csproj] [D:\a\1\s\build.proj]
ExpressRoutePort\Authorization\AddAzureExpressRoutePortAuthorizationCommand.cs(73,95): error CS1061: 'INetworkManagementClient' does not contain a definition for 'ExpressRoutePortAuthorizations' and no accessible extension method 'ExpressRoutePortAuthorizations' accepting a first argument of type 'INetworkManagementClient' could be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\src\Network\Network\Network.csproj] [D:\a\1\s\build.proj]
ExpressRoutePort\Authorization\GetAzureExpressRoutePortAuthorizationCommand.cs(42,99): error CS1061: 'INetworkManagementClient' does not contain a definition for 'ExpressRoutePortAuthorizations' and no accessible extension method 'ExpressRoutePortAuthorizations' accepting a first argument of type 'INetworkManagementClient' could be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\src\Network\Network\Network.csproj] [D:\a\1\s\build.proj]
ExpressRoutePort\Authorization\GetAzureExpressRoutePortAuthorizationCommand.cs(49,101): error CS1061: 'INetworkManagementClient' does not contain a definition for 'ExpressRoutePortAuthorizations' and no accessible extension method 'ExpressRoutePortAuthorizations' accepting a first argument of type 'INetworkManagementClient' could be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\src\Network\Network\Network.csproj] [D:\a\1\s\build.proj]
ExpressRoutePort\Authorization\RemoveAzureExpressRoutePortAuthorizationCommand.cs(46,56): error CS1061: 'INetworkManagementClient' does not contain a definition for 'ExpressRoutePortAuthorizations' and no accessible extension method 'ExpressRoutePortAuthorizations' accepting a first argument of type 'INetworkManagementClient' could be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\src\Network\Network\Network.csproj] [D:\a\1\s\build.proj]

could you check your assembly?

new sdks are not generated yet.

Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you upload your local nuget packages to our tools\LocalFeed? So that our check pipelines can work now. They can be removed when the SDKs are generated. BTW, why your target branch is network-2021-08-01?

utbarn-ms and others added 5 commits March 31, 2022 19:02
…ExpressRoutePortAuthorizationCommand.cs

Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>
…ExpressRoutePortAuthorizationCommand.cs

Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>
@isra-fel isra-fel self-assigned this Apr 1, 2022
@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel isra-fel merged commit 2ef7869 into Azure:network-2021-08-01 Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants