Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL] Add examples of Create Server and MI with TDE CMK #17611

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

viparek
Copy link
Contributor

@viparek viparek commented Mar 24, 2022

Description

Adding new examples for Create SQL Server and create managed instance with TDE CMK

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@viparek viparek marked this pull request as ready for review March 28, 2022 16:30
Copy link
Contributor

@strehan1993 strehan1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add dummy resource ids and dummy urls instead of plaintext

src/Sql/Sql/help/New-AzSqlInstance.md Outdated Show resolved Hide resolved
@isra-fel isra-fel self-assigned this Mar 31, 2022
strehan1993
strehan1993 previously approved these changes Mar 31, 2022
@viparek
Copy link
Contributor Author

viparek commented Mar 31, 2022

@isra-fel This is reviewed by the owning team and ready to merge. Please sign off and merge this PR.

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If PR only modifies documents, changelog does not have to be updated.

Copy link

@ericshape ericshape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BethanyZhou
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@BethanyZhou BethanyZhou merged commit 852ba4e into Azure:main Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants