Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that can't parse CustomIpPrefixParent in CustomIpPrefix commands #18218

Merged
merged 5 commits into from
Jun 8, 2022

Conversation

gitlwh
Copy link
Contributor

@gitlwh gitlwh commented May 17, 2022

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@wyunchi-ms
Copy link
Contributor

Changing of the property in output will cause breaking changes. Can you show me the context of this issue?

@gitlwh
Copy link
Contributor Author

gitlwh commented May 19, 2022

@wyunchi-ms
image
this is a bug causing issue.
the type given by sdk is resourceid but we were trying to parse it into customipprefix.

@gitlwh gitlwh added the Preview label May 19, 2022
Weiheng Li added 3 commits June 1, 2022 23:10
@wyunchi-ms
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@wyunchi-ms wyunchi-ms merged commit 05006ce into Azure:network-2022-01-01 Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants