Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Az.Compute XML Comments #18408

Merged
merged 2 commits into from
Jun 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ public BlobInventoryPolicy()
/// "Microsoft.Storage/storageAccounts"</param>
/// <param name="lastModifiedTime">Returns the last modified date and
/// time of the blob inventory policy.</param>
/// <param name="systemData"></param>
public BlobInventoryPolicy(BlobInventoryPolicySchema policy, string id = default(string), string name = default(string), string type = default(string), System.DateTime? lastModifiedTime = default(System.DateTime?), SystemData systemData = default(SystemData))
: base(id, name, type)
{
Expand Down
2 changes: 2 additions & 0 deletions src/Compute/Compute/Common/AzureContextAdapterExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ public static class AzureContextAdapterExtensions
/// Get the current storage account.
/// </summary>
/// <param name="context">The current Azure context.</param>
/// <param name="provider"></param>
/// <returns>The current storage account, or null, if no current storage account is set.</returns>
public static CloudStorageAccount GetCurrentStorageAccount(this IAzureContext context, IStorageServiceProvider provider)
{
Expand Down Expand Up @@ -92,6 +93,7 @@ public static IStorageContext GetStorageContext(this IStorageService service)
/// </summary>
/// <param name="provider">The storage service provider to retrieve storage service details</param>
/// <param name="accountName">The storage accoutn name</param>
/// <param name="resourceGroupName"></param>
/// <returns>A CloudStorageAccount client for storage data plane tasks</returns>
public static CloudStorageAccount GetCloudStorageAccount(this IStorageServiceProvider provider, string accountName, string resourceGroupName = null)
{
Expand Down
2 changes: 2 additions & 0 deletions src/Compute/Compute/Common/DiagnosticsHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -661,6 +661,8 @@ private static string GetEndpointFromStorageContext(IStorageContext context)
/// </summary>
/// <param name="publicConfigPath">Public configuration file path</param>
/// <param name="privateConfigPath">Private configuration file path, can be empty</param>
/// <param name="resourceId"></param>
/// <param name="cmdlet"></param>
/// <param name="storageClient">Storage client</param>
/// <returns>A tuple with public configuration as first element and private configuration as second element</returns>
public static Tuple<Hashtable, Hashtable> GetConfigurationsFromFiles(string publicConfigPath, string privateConfigPath, string resourceId, Cmdlet cmdlet, IStorageManagementClient storageClient)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,10 @@ private string GetBase64Encoding(object obj)
/// <summary>
/// find the snapshot with the tags
/// </summary>
/// <param name="azContext"></param>
/// <param name="blobUris"></param>
/// <param name="snapshotTag"></param>
/// <param name="taskId"></param>
/// <param name="storageCredentialsFactory"></param>
/// <param name="snapshotQuery"></param>
/// <returns></returns>
public List<CloudPageBlob> FindSnapshot(IAzureContext azContext, List<string> blobUris, List<StorageCredentialsFactory> storageCredentialsFactory, Dictionary<string, string> snapshotQuery)
{
Expand Down Expand Up @@ -178,13 +178,8 @@ public AzureVMBackupBlobSasUris GenerateBlobSasUris(List<string> blobUris, IAzur
/// <summary>
/// remove the vmbackups with the metadata key "vmbackuptag" and value snapshotTag, snapshotTag is the parameter passed in.
/// </summary>
/// <param name="resourceGroupName"></param>
/// <param name="vmName"></param>
/// <param name="virtualMachineExtensionType"></param>
/// <param name="location"></param>
/// <param name="virtualMachineResponse"></param>
/// <param name="profile"></param>
/// <param name="VirtualMachineExtensionClient"></param>
/// <param name="vmConfig"></param>
/// <param name="virtualMachineExtensionBaseCmdlet"></param>
/// <param name="snapshotTag"></param>
public void RemoveSnapshot(AzureVMBackupConfig vmConfig, string snapshotTag, VirtualMachineExtensionBaseCmdlet virtualMachineExtensionBaseCmdlet)
{
Expand Down Expand Up @@ -216,11 +211,7 @@ public void RemoveSnapshot(AzureVMBackupConfig vmConfig, string snapshotTag, Vir
/// <summary>
/// we only support the Linux box now, if it's a windows, one AzureVMBackupException would be thrown.
/// </summary>
/// <param name="resourceGroupName"></param>
/// <param name="vmName"></param>
/// <param name="virtualMachineExtensionType"></param>
/// <param name="location"></param>
/// <param name="virtualMachineResponse"></param>
/// <param name="vmConfig"></param>
/// <param name="snapshotTag"></param>
/// <param name="virtualMachineExtensionBaseCmdlet"></param>
public void CreateSnapshotForDisks(AzureVMBackupConfig vmConfig, string snapshotTag, VirtualMachineExtensionBaseCmdlet virtualMachineExtensionBaseCmdlet)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ public class VirtualHardDiskSettingData
/// </param>
/// <param name="blockSize">The block size of the virtual hard disk.</param>
/// <param name="logicalSectorSize">The logical sector size of the virtual hard disk.
/// </param>
/// <param name="physicalSectorSize">The physical sector size of the virtual hard disk.
/// </param>
public
Expand Down