Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gallery Confidential VM feature #19359

Merged
merged 20 commits into from
Sep 1, 2022
Merged

Conversation

grizzlytheodore
Copy link
Member

@grizzlytheodore grizzlytheodore commented Aug 30, 2022

Description

adding a feature in PS design: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1222

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@grizzlytheodore
Copy link
Member Author

@wyunchi-ms @isra-fel addressed your comments. please review/merge

@isra-fel isra-fel merged commit 4a82d5f into release-2022-09-06 Sep 1, 2022
@isra-fel isra-fel deleted the feature/cplat-cvmGallery branch September 1, 2022 01:56
hiaga pushed a commit to MabOneSdk/azure-powershell that referenced this pull request Sep 2, 2022
* update sdk package

* implement

* suppress breaking change

* update md file and changelog

* Fix ps730previewbug (Azure#19351)

* update sdk package

* suppress breaking change

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>

* Update src/RecoveryServices/RecoveryServices.SiteRecovery.Test/RecoveryServices.SiteRecovery.Test.csproj

* suppress example issues

* fix example issues

* example and changelog

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
Co-authored-by: Yeming Liu <11371776+isra-fel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants