Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some example issues #19423

Merged
merged 8 commits into from
Sep 8, 2022
Merged

fix some example issues #19423

merged 8 commits into from
Sep 8, 2022

Conversation

VeryEarly
Copy link
Contributor

@VeryEarly VeryEarly commented Sep 7, 2022

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

BethanyZhou and others added 6 commits July 19, 2022 15:12
* Delete src/SecurityInsights directory

* Move SecurityInsights to share/SecurityInsights

* Update Changelog.md

* Update Az.SecurityInsights.psd1

* Update AssemblyInfo.cs

* Update src/SecurityInsights/Az.SecurityInsights.psd1

Co-authored-by: azure-powershell-bot <65331932+azure-powershell-bot@users.noreply.github.com>
* Move SecurityInsights to Az.SecurityInsights-preview

* suppress breakingchange and signature issues

* suppress example issues cannot be resolved

* fix examples

* suppress one more example issues

* example issues

* example issue

Co-authored-by: azure-powershell-bot <65331932+azure-powershell-bot@users.noreply.github.com>
* Az.SecurityInsights 2.0.0-preview release

* add az.psd1
az.securityinsights preview sync main branch
@VeryEarly VeryEarly self-assigned this Sep 7, 2022
@VeryEarly
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly force-pushed the yabo/Az.SecurityInsights-preview branch from 9cc75af to 5124653 Compare September 7, 2022 09:12
@VeryEarly VeryEarly changed the base branch from main to Az.SecurityInsights-preview September 7, 2022 09:12
@VeryEarly
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly changed the base branch from Az.SecurityInsights-preview to main September 8, 2022 03:17
@VeryEarly
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms wyunchi-ms merged commit d791248 into main Sep 8, 2022
@VeryEarly VeryEarly deleted the yabo/Az.SecurityInsights-preview branch September 8, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants