Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[InAccountRestore] Introducing new PowerShell commands for InAccount Restore of Deleted Database/ Containers feature #19601

Merged
merged 11 commits into from
Sep 29, 2022
Merged

[InAccountRestore] Introducing new PowerShell commands for InAccount Restore of Deleted Database/ Containers feature #19601

merged 11 commits into from
Sep 29, 2022

Conversation

ddhamotharan
Copy link
Contributor

@ddhamotharan ddhamotharan commented Sep 23, 2022 •
edited
Loading

Introducing PowerShell support for the new InAccount Restore of Deleted Database / Containers feature from and adding test coverage for the newly added commands

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@wyunchi-ms
Copy link
Contributor

  1. Missing help file for new cmdlets.
  2. Please fix the failed test cases.

amar-sagare and others added 4 commits September 26, 2022 19:50
@amar-sagare @VeryEarly @ddhamotharan
Cosmos DB: Update to 2.0.0 and Add support for NetworkAclBypass in Ac…
3b3d6af 
…count (Azure#14211)

* Make changes for Network Acl Bypass

* Add help file updates

* Changes with enum not as string

* rerun tests

* Remove extra line

* rerun gremlin test with updated

* Update ChangeLog.md

Co-authored-by: Yabo Hu <yabhu@microsoft.com>
@ddhamotharan
InAccount Restore feature powershell support
cecde6f
@ddhamotharan
update session records
3276143
@ddhamotharan
update session records and help files
b7719e4
amisi01
amisi01 reviewed Sep 27, 2022
View reviewed changes
src/CosmosDB/CosmosDB/ChangeLog.md Outdated Show resolved Hide resolved
src/CosmosDB/CosmosDB/MongoDB/RestoreAzCosmosDBMongoDBCollection.cs Outdated Show resolved Hide resolved
src/CosmosDB/CosmosDB/MongoDB/RestoreAzCosmosDBMongoDBCollection.cs Outdated Show resolved Hide resolved
src/CosmosDB/CosmosDB/MongoDB/RestoreAzCosmosDBMongoDBDatabase.cs Outdated Show resolved Hide resolved
src/CosmosDB/CosmosDB/SQL/RestoreAzCosmosDBSqlContainer.cs Outdated Show resolved Hide resolved
src/CosmosDB/CosmosDB/SQL/RestoreAzCosmosDBSqlDatabase.cs Outdated Show resolved Hide resolved
src/CosmosDB/CosmosDB/help/Restore-AzCosmosDBMongoDBCollection.md Show resolved Hide resolved
src/CosmosDB/CosmosDB/help/Restore-AzCosmosDBMongoDBCollection.md Show resolved Hide resolved
src/CosmosDB/CosmosDB/help/Restore-AzCosmosDBSqlDatabase.md Show resolved Hide resolved
@wyunchi-ms
Copy link
Contributor

Please fix the example issues.

@vidai-msft
Copy link
Contributor

@ddhamotharan the tests failed because of no SubscriptionId recorded in the json file. Can you please help confirm if in the testcredentials.json file, it has SubscriptionId configured?

@wyunchi-ms
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

wyunchi-ms
wyunchi-ms previously approved these changes Sep 29, 2022
View reviewed changes
@vidai-msft
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@wyunchi-ms
Copy link
Contributor

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@wyunchi-ms wyunchi-ms merged commit d1ac42c into Azure:Az.CosmosDB-preview Sep 29, 2022
@himanshudhawale himanshudhawale mentioned this pull request Apr 6, 2023
Merged
1 task
ddhamotharan added a commit to ddhamotharan/azure-powershell that referenced this pull request Jan 25, 2024
@ddhamotharan @amar-sagare @VeryEarly
[InAccountRestore] Introducing new PowerShell commands for InAccount …
458e3cd 
…Restore of Deleted Database/ Containers feature (Azure#19601)

* Cosmos DB: Update to 2.0.0 and Add support for NetworkAclBypass in Account (Azure#14211)

* Make changes for Network Acl Bypass

* Add help file updates

* Changes with enum not as string

* rerun tests

* Remove extra line

* rerun gremlin test with updated

* Update ChangeLog.md

Co-authored-by: Yabo Hu <yabhu@microsoft.com>

* InAccount Restore feature powershell support

* update session records

* update session records and help files

* address comments for validation and in changelog.md

* add session records for new tests and update help files

* add update help files

* update session records after rebase

* updated New-AzCosmosDBAccount.md and session records

* update session records with subscription id in variables and added ExampleIssues.csv

* update nuget package version and remove localfeed files

Co-authored-by: amar-sagare <45947937+amar-sagare@users.noreply.github.com>
Co-authored-by: Yabo Hu <yabhu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amisi01 amisi01 amisi01 left review comments

@wyunchi-ms wyunchi-ms wyunchi-ms approved these changes

Assignees
No one assigned
Labels
needs-revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ddhamotharan @wyunchi-ms @vidai-msft @amisi01 @amar-sagare