Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Get-AzHost cmdlet to return Host for -ResourceId parameterset #19770

Merged
merged 5 commits into from
Oct 17, 2022

Conversation

pselugar
Copy link
Contributor

@pselugar pselugar commented Oct 10, 2022

Description

  • Updated Get-AzHost cmdlet logic to return Host for -ResouceId ParameterSet.
  • Manually tested the changes (Debug).
  • Added recorded Test to validate changes.
  • Incorrect path was provided for field String ResourceName in the GetResourceName() call : "Microsoft.Compute/hosts" -> "Microsoft.Compute/hostGroups". Fixing this made hostGroupName fetch non-null value.
  • GetInstanceId() is the correct function call for hostName instead of GetResourceName() to fetch non null value for hostName . (Check out DedicatedHostDeleteMethods.cs file for reference)
  • GitHub Issue

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@VeryEarly
Copy link
Contributor

please delete ADO workitem link in this PR

@VeryEarly VeryEarly self-assigned this Oct 12, 2022
@pselugar
Copy link
Contributor Author

please delete ADO workitem link in this PR

Done thanks

@VeryEarly
Copy link
Contributor

VeryEarly commented Oct 14, 2022

is this PR ready to be reviewed/merged? Please remove the tag "Do Not Merge" if so

@pselugar
Copy link
Contributor Author

is this PR ready to be reviewed/merged? Please remove the tag "Do Not Merge" if so
It's ready to be merged.
removed the "Do Not Merge" label

@VeryEarly VeryEarly merged commit 95f926a into main Oct 17, 2022
@VeryEarly VeryEarly deleted the bug/CPlat-pselugar-GetAzHost branch October 17, 2022 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants