-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Get-AzHost
cmdlet to return Host for -ResourceId parameterset
#19770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pselugar
requested review from
bilaakpan-ms,
Sandido,
haagha and
grizzlytheodore
as code owners
October 10, 2022 21:20
Sandido
previously requested changes
Oct 11, 2022
please delete ADO workitem link in this PR |
Done thanks |
is this PR ready to be reviewed/merged? Please remove the tag "Do Not Merge" if so |
|
VeryEarly
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Get-AzHost
cmdlet logic to return Host for-ResouceId
ParameterSet.String ResourceName
in theGetResourceName()
call :"Microsoft.Compute/hosts"
->"Microsoft.Compute/hostGroups"
. Fixing this madehostGroupName
fetch non-null value.GetInstanceId()
is the correct function call forhostName
instead ofGetResourceName()
to fetch non null value forhostName
. (Check outDedicatedHostDeleteMethods.cs
file for reference)Checklist
CONTRIBUTING.md
and reviewed the following information:generation
branch.ChangeLog.md
file(s) appropriatelyChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
## Upcoming Release
header in the past tense. Add changelog in description section if PR goes intogeneration
branch.ChangeLog.md
if no new release is required, such as fixing test case only.