Enable passing a tenant domain to Connect-AzureRmAccount #6822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cormacpayne
force-pushed
the
domain-tenant
branch
from
91f1996
to
ef7841d
Compare
|
Also resolves issue #6709 |
markcowl
requested changes
Aug 1, 2018
| promptAction)?.FirstOrDefault(); | ||
| if (tenant == null) | ||
| { | ||
| throw new ArgumentNullException(string.Format("Could not find tenant id for provided tenant domain '{0}'.", tenantId)); |
There was a problem hiding this comment.
Is there a way that we can add a test to exercise this exception?
There was a problem hiding this comment.
even if this is a live only test, it would behoove us to have this to prevent regressions
…ned from initial call for SPN
markcowl
approved these changes
Aug 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #3974 and #6709
Checklist
CONTRIBUTING.mdplatyPSmodule