-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Standard_Microsoft in Cdn Pricing sku #7210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yoj need to fix the test, its broken :
https://azuresdkci.westus2.cloudapp.azure.com/job/powershell/7410/artifact/src/Publish/TestResults/FailingTests/Microsoft.Azure.Commands.Cdn.Test.ScenarioTests.dll.html
0.2198636s ✘ Microsoft.Azure.Commands.Cdn.Test.ScenarioTests.ScenarioTest.ProfileTests.TestProfileCrud
System.Management.Automation.RuntimeException : Assertion failed because expected 'Standard_Microsoft' does not match actual 'Standard_Verizon'\r\n---- System.Management.Automation.RuntimeException : Assertion failed because expected 'Standard_Microsoft' does not match actual 'Standard_Verizon'
Did you record the test after making the change? The recorded json still has the old value : https://github.com/Azure/azure-powershell/pull/7210/files#diff-caf7f41852e5b989f395ccef252280abR163
@@ -19,6 +19,9 @@ | |||
--> | |||
## Current Release | |||
|
|||
## Version 5.0.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the version header, leave the change description directly under Current Release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix the test. Thanks!
ping @hytao |
@hytao Code complete is today, please update - we will not accept changes after today for Ignite. |
Description
Adding Standard_Microsoft in CDN pricing sku.
Old PR link #7200
Swagger PR link Azure/azure-rest-api-specs#3628
SDK PR link Azure/azure-sdk-for-net#4730
Checklist
CONTRIBUTING.md
platyPS
module