Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compute 2021-07-01 and 2021-04-01 #1859

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

grizzlytheodore
Copy link
Member

@grizzlytheodore grizzlytheodore commented Aug 25, 2021

update with this swagger change: Azure/azure-rest-api-specs#15479

@grizzlytheodore
Copy link
Member Author

grizzlytheodore commented Aug 25, 2021

@anthony-c-martin
is this part still a thing?
Ensure that any $refs to resource types that you are adding has been added to the following top-level template schema: schemas/2019-04-01/deploymentTemplate.json

I don't see any change in that file from the generation

@anthony-c-martin
Copy link
Member

@anthony-c-martin
is this part still a thing?
Ensure that any $refs to resource types that you are adding has been added to the following top-level template schema: schemas/2019-04-01/deploymentTemplate.json

I don't see any change in that file from the generation

Yes, that's still required. The top-level schema is the index for discovering resource schemas, so by not adding to this file, your schemas won't be discoverable.

We've optimized the generation process for provider which are onboarded for auto generation; some manual steps are still required for RPs that are not onboarded.

@grizzlytheodore
Copy link
Member Author

@anthony-c-martin thank you for the answers. please review/merge!

@anthony-c-martin anthony-c-martin merged commit 29ba1b5 into Azure:main Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants