Skip to content

Commit

Permalink
Removed unused XXUpdate models, Added @secret for password,
Browse files Browse the repository at this point in the history
  • Loading branch information
@allenjzhang
allenjzhang committed Feb 13, 2024
1 parent ac68942 commit 2f9d6ff
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 408 deletions.
96 changes: 2 additions & 94 deletions specification/scvmm/ScVmm.Management/models.tsp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ model VmmCredential {

/** Password to use to connect to VmmServer. */
@visibility("create", "update")
@secret
password?: string;
}

Expand Down Expand Up @@ -667,100 +668,6 @@ model Checkpoint {
description?: string;
}

/** Defines the resource properties. */
model HardwareProfileUpdate {
/** MemoryMB is the size of a virtual machine's memory, in MB. */
#suppress "@azure-tools/typespec-azure-core/casing-style" "MB is distinct from Mb"
memoryMB?: int32;

/** Gets or sets the number of vCPUs for the vm. */
cpuCount?: int32;

/** Gets or sets a value indicating whether to enable processor compatibility mode for live migration of VMs. */
limitCpuForMigration?: LimitCpuForMigration;

/** Gets or sets a value indicating whether to enable dynamic memory or not. */
dynamicMemoryEnabled?: DynamicMemoryEnabled;

/** Gets or sets the max dynamic memory for the vm. */
#suppress "@azure-tools/typespec-azure-core/casing-style" "MB is distinct from Mb"
dynamicMemoryMaxMB?: int32;

/** Gets or sets the min dynamic memory for the vm. */
#suppress "@azure-tools/typespec-azure-core/casing-style" "MB is distinct from Mb"
dynamicMemoryMinMB?: int32;
}

/** Defines the resource properties. */
model StorageProfileUpdate {
/** Gets or sets the list of virtual disks associated with the virtual machine. */
disks?: VirtualDiskUpdate[];
}

/** Virtual disk model */
model VirtualDiskUpdate {
/** Gets or sets the name of the disk. */
name?: string;

/** Gets or sets the disk id. */
diskId?: string;

/** Gets or sets the disk total size. */
#suppress "@azure-tools/typespec-azure-core/casing-style" "GB is distinct from Gb"
diskSizeGB?: int32;

/** Gets or sets the disk bus. */
bus?: int32;

/** Gets or sets the disk lun. */
lun?: int32;

/** Gets or sets the disk bus type. */
busType?: string;

/** Gets or sets the disk vhd type. */
vhdType?: string;

/** The QoS policy for the disk. */
storageQosPolicy?: StorageQosPolicyDetails;
}

/** Defines the resource properties. */
model NetworkProfileUpdate {
/** Gets or sets the list of network interfaces associated with the virtual machine. */
networkInterfaces?: NetworkInterfaceUpdate[];
}

/** Network Interface model */
model NetworkInterfaceUpdate {
/** Gets or sets the name of the network interface. */
name?: string;

/** Gets or sets the nic MAC address. */
macAddress?: string;

/** Gets or sets the ARM Id of the Microsoft.ScVmm/virtualNetwork resource to connect the nic. */
virtualNetworkId?: VirtualNetworkId;

/** Gets or sets the ipv4 address type. */
ipv4AddressType?: AllocationMethod;

/** Gets or sets the ipv6 address type. */
ipv6AddressType?: AllocationMethod;

/** Gets or sets the mac address type. */
macAddressType?: AllocationMethod;

/** Gets or sets the nic id. */
nicId?: string;
}

/** Specifies the vmmServer infrastructure specific settings for the virtual machine instance for update. */
model InfrastructureProfileUpdate {
/** Type of checkpoint supported for the vm. */
checkpointType?: string;
}

/** Defines the stop action properties. */
model StopVirtualMachineOptions {
/** Gets or sets a value indicating whether to request non-graceful VM shutdown. True value for this flag indicates non-graceful shutdown whereas false indicates otherwise. Defaults to false. */
Expand Down Expand Up @@ -836,6 +743,7 @@ model GuestCredential {

/** Gets or sets the password to connect with the guest. */
@visibility("create", "update")
@secret
password: string;
}

Expand Down
163 changes: 6 additions & 157 deletions specification/scvmm/resource-manager/Microsoft.ScVmm/stable/2023-10-07/scvmm.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3503,11 +3503,13 @@
},
"password": {
"type": "string",
"format": "password",
"description": "Gets or sets the password to connect with the guest.",
"x-ms-mutability": [
"update",
"create"
]
],
"x-ms-secret": true
}
},
"required": [
Expand Down Expand Up @@ -3554,40 +3556,6 @@
}
}
},
"HardwareProfileUpdate": {
"type": "object",
"description": "Defines the resource properties.",
"properties": {
"memoryMB": {
"type": "integer",
"format": "int32",
"description": "MemoryMB is the size of a virtual machine's memory, in MB."
},
"cpuCount": {
"type": "integer",
"format": "int32",
"description": "Gets or sets the number of vCPUs for the vm."
},
"limitCpuForMigration": {
"$ref": "#/definitions/LimitCpuForMigration",
"description": "Gets or sets a value indicating whether to enable processor compatibility mode for live migration of VMs."
},
"dynamicMemoryEnabled": {
"$ref": "#/definitions/DynamicMemoryEnabled",
"description": "Gets or sets a value indicating whether to enable dynamic memory or not."
},
"dynamicMemoryMaxMB": {
"type": "integer",
"format": "int32",
"description": "Gets or sets the max dynamic memory for the vm."
},
"dynamicMemoryMinMB": {
"type": "integer",
"format": "int32",
"description": "Gets or sets the min dynamic memory for the vm."
}
}
},
"HttpProxyConfiguration": {
"type": "object",
"description": "HTTP Proxy configuration for the VM.",
Expand Down Expand Up @@ -3705,16 +3673,6 @@
}
}
},
"InfrastructureProfileUpdate": {
"type": "object",
"description": "Specifies the vmmServer infrastructure specific settings for the virtual machine instance for update.",
"properties": {
"checkpointType": {
"type": "string",
"description": "Type of checkpoint supported for the vm."
}
}
},
"InventoryItem": {
"type": "object",
"description": "Defines the inventory item.",
Expand Down Expand Up @@ -3953,48 +3911,6 @@
}
}
},
"NetworkInterfaceUpdate": {
"type": "object",
"description": "Network Interface model",
"properties": {
"name": {
"type": "string",
"description": "Gets or sets the name of the network interface."
},
"macAddress": {
"type": "string",
"description": "Gets or sets the nic MAC address."
},
"virtualNetworkId": {
"type": "string",
"format": "arm-id",
"description": "Gets or sets the ARM Id of the Microsoft.ScVmm/virtualNetwork resource to connect the nic.",
"x-ms-arm-id-details": {
"allowedResources": [
{
"type": "Microsoft.ScVmm/virtualNetwork"
}
]
}
},
"ipv4AddressType": {
"$ref": "#/definitions/AllocationMethod",
"description": "Gets or sets the ipv4 address type."
},
"ipv6AddressType": {
"$ref": "#/definitions/AllocationMethod",
"description": "Gets or sets the ipv6 address type."
},
"macAddressType": {
"$ref": "#/definitions/AllocationMethod",
"description": "Gets or sets the mac address type."
},
"nicId": {
"type": "string",
"description": "Gets or sets the nic id."
}
}
},
"NetworkProfile": {
"type": "object",
"description": "Defines the resource properties.",
Expand All @@ -4012,20 +3928,6 @@
}
}
},
"NetworkProfileUpdate": {
"type": "object",
"description": "Defines the resource properties.",
"properties": {
"networkInterfaces": {
"type": "array",
"description": "Gets or sets the list of network interfaces associated with the virtual machine.",
"items": {
"$ref": "#/definitions/NetworkInterfaceUpdate"
},
"x-ms-identifiers": []
}
}
},
"OsProfileForVmInstance": {
"type": "object",
"description": "Defines the resource properties.",
Expand Down Expand Up @@ -4232,20 +4134,6 @@
}
}
},
"StorageProfileUpdate": {
"type": "object",
"description": "Defines the resource properties.",
"properties": {
"disks": {
"type": "array",
"description": "Gets or sets the list of virtual disks associated with the virtual machine.",
"items": {
"$ref": "#/definitions/VirtualDiskUpdate"
},
"x-ms-identifiers": []
}
}
},
"StorageQosPolicy": {
"type": "object",
"description": "The StorageQoSPolicy definition.",
Expand Down Expand Up @@ -4382,47 +4270,6 @@
}
}
},
"VirtualDiskUpdate": {
"type": "object",
"description": "Virtual disk model",
"properties": {
"name": {
"type": "string",
"description": "Gets or sets the name of the disk."
},
"diskId": {
"type": "string",
"description": "Gets or sets the disk id."
},
"diskSizeGB": {
"type": "integer",
"format": "int32",
"description": "Gets or sets the disk total size."
},
"bus": {
"type": "integer",
"format": "int32",
"description": "Gets or sets the disk bus."
},
"lun": {
"type": "integer",
"format": "int32",
"description": "Gets or sets the disk lun."
},
"busType": {
"type": "string",
"description": "Gets or sets the disk bus type."
},
"vhdType": {
"type": "string",
"description": "Gets or sets the disk vhd type."
},
"storageQosPolicy": {
"$ref": "#/definitions/StorageQosPolicyDetails",
"description": "The QoS policy for the disk."
}
}
},
"VirtualMachineCreateCheckpoint": {
"type": "object",
"description": "Defines the create checkpoint action properties.",
Expand Down Expand Up @@ -5036,11 +4883,13 @@
},
"password": {
"type": "string",
"format": "password",
"description": "Password to use to connect to VmmServer.",
"x-ms-mutability": [
"update",
"create"
]
],
"x-ms-secret": true
}
}
},
Expand Down
Loading

0 comments on commit 2f9d6ff

Please sign in to comment.