Skip to content

Commit

Permalink
[Hub Generated] Review request for Microsoft.Security to add version …
Browse files Browse the repository at this point in the history
…stable/2020-01-01 (#13078)

* fixing serverVulnerabilityAssessments swagger correctness in the delete action (instead of synchronous operation it is an asynchronous one) - so adding the operationResults path

* fix the examples path

* updates to the delete and operationResults responses and status codes

* removing the long-running-operation from the put, and adding the synchronous status codes to the delete as well

* fixing unconnected validation errors in SDK Track2 Validation

* fixing SDK Track2 Validation errors - the same specifications were used twice under the same tag (the commented out version and a newer preview api-version) - which caused errors like: "Duplicate Operation '{Get/List}' detected"

* Revert "fixing SDK Track2 Validation errors - the same specifications were used twice under the same tag (the commented out version and a newer preview api-version) - which caused errors like: "Duplicate Operation '{Get/List}' detected""

This reverts commit 12baa06.

* Revert "fixing unconnected validation errors in SDK Track2 Validation"

This reverts commit 056ae33.

* removing the operationResults path and example from the swagger - as this resource type does not need to be declared in the Swagger (verified in ARM office hours)
  • Loading branch information
Nomigori96MS authored Feb 26, 2021
1 parent cb2ecbb commit 353bce7
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"serverVulnerabilityAssessment": "default"
},
"responses": {
"202": {},
"200": {},
"204": {}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,10 @@
"ServerVulnerabilityAssessment"
],
"operationId": "ServerVulnerabilityAssessment_Delete",
"x-ms-long-running-operation": true,
"x-ms-long-running-operation-options": {
"final-state-via": "location"
},
"parameters": [
{
"$ref": "../../../common/v1/types.json#/parameters/SubscriptionId"
Expand Down Expand Up @@ -285,11 +289,14 @@
}
],
"responses": {
"202": {
"description": "Accepted - the asynchronous delete operation has started."
},
"200": {
"description": "OK"
"description": "OK - deleted successfully."
},
"204": {
"description": "No Content - Resource does not exist"
"description": "No Content - the resource did not exist in the first place."
},
"default": {
"description": "Error response describing why the operation failed.",
Expand Down

0 comments on commit 353bce7

Please sign in to comment.