Skip to content

Commit

Permalink
[Hub Generated] Review request for Microsoft.Insights to add version …
Browse files Browse the repository at this point in the history
…stable/2018-09-01 (#12233)

* Fix swagger validation for 2018-09-01 version

* Fixed swagger validations for version 2017-11-01

* reverted 2017 changes!

* reverted ErrorResponse thing and add a suppresion

* added suppresion for baseline_API

* fixed enum

* fixed the statistics

* renamed suppression rule

* added missing timestamps

* added int format

* fixed namespace

* fixed suppression

* added missing API

* fixed 4007 thing

* deleted api version i've added
  • Loading branch information
yashmuel authored Jan 6, 2021
1 parent ae379e1 commit 7c06dc7
Show file tree
Hide file tree
Showing 3 changed files with 46 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
}
},
"paths": {
"/{resourceUri}/providers/microsoft.insights/baseline/{metricName}": {
"/{resourceUri}/providers/Microsoft.Insights/baseline/{metricName}": {
"get": {
"tags": [
"Baseline"
Expand Down Expand Up @@ -103,7 +103,7 @@
}
}
},
"/{resourceUri}/providers/microsoft.insights/baseline": {
"/{resourceUri}/providers/Microsoft.Insights/baseline": {
"get": {
"tags": [
"Baseline"
Expand Down Expand Up @@ -312,6 +312,15 @@
"description": "A single high threshold value."
},
"description": "The high thresholds of the baseline."
},
"timestamps": {
"type": "array",
"items": {
"type": "string",
"format": "date-time",
"description": "the timestamp for the baseline value in ISO 8601 format."
},
"description": "the array of timestamps of the baselines."
}
},
"required": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
}
},
"paths": {
"/{resourceUri}/providers/microsoft.insights/calculatebaseline": {
"/{resourceUri}/providers/Microsoft.Insights/calculatebaseline": {
"post": {
"tags": [
"Baseline"
Expand Down Expand Up @@ -154,6 +154,28 @@
"$ref": "#/definitions/Baseline"
},
"description": "The baseline values for each sensitivity."
},
"statistics": {
"type": "object",
"properties": {
"isEligible": {
"type": "string",
"description": "is series eligible for dynamic threshold analysis"
},
"status": {
"type": "array",
"items": {
"type": "string"
},
"description": "The list of extended status for calculating the baseline."
},
"seasonalityPeriod": {
"type": "integer",
"format": "int32",
"description": "The seasonality period for calculating the baseline."
}
},
"description": "The statistics"
}
},
"required": [
Expand Down Expand Up @@ -195,6 +217,15 @@
"description": "A single high threshold value."
},
"description": "The high thresholds of the baseline."
},
"timestamps": {
"type": "array",
"items": {
"type": "string",
"format": "date-time",
"description": "the timestamp for the baseline value in ISO 8601 format."
},
"description": "the array of timestamps of the baselines."
}
},
"required": [
Expand Down
3 changes: 3 additions & 0 deletions specification/monitor/resource-manager/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -618,6 +618,9 @@ directive:
from: dataCollectionRuleAssociations_API.json
where: $.paths
reason: 'Operations API is defined in a separate swagger spec for Microsoft.Insights namespace (https://github.com/Azure/azure-rest-api-specs/blob/master/specification/monitor/resource-manager/Microsoft.Insights/stable/2015-04-01/operations_API.json)'
- suppress: R4007
from: calculateBaseline_API.json
reason: 'Updating the error response to the new format would be a breaking change.'
- suppress: R4007
from: baseline_API.json
reason: 'Updating the error response to the new format would be a breaking change.'
Expand Down

0 comments on commit 7c06dc7

Please sign in to comment.