Skip to content

Commit

Permalink
Update UserAssignedIdentities spec in Web (#5288)
Browse files Browse the repository at this point in the history
* Update UserAssignedIdentities spec in Web

Microsoft.Web recently added support for UserAssigned managed service identities (in preview), but the swagger spec is incorrect for the identity payload as it follows the old construct of sending an array of identityIds as opposed to the updated spec which instead sends a dictionary object called userAssignedIdentities. 

Spec + history outlined here:
http://sharepoint/sites/AzureUX/Sparta/_layouts/15/WopiFrame2.aspx?sourcedoc=%7b633632B4-02E4-4DE2-92A9-EDCAF9BE73D4%7d&file=ARM%2BMSI.docx&action=default 

Our swagger contains identityids[] because of previous work to future support UserAssigned identities, but never released the feature in that state, rather we opted to wait for the new spec to be supported and then integrated with that on our end. 

Our MSI implementation reflects Microsoft.Compute's spec for user assigned.

https://github.com/Azure/azure-rest-api-specs/blob/78e1feab142c605839aa3cec23442ca26b8ef04d/specification/compute/resource-manager/Microsoft.Compute/stable/2018-06-01/compute.json

* fix linterdiff tool
  • Loading branch information
Hamster-Huey authored and jhendrixMSFT committed Mar 4, 2019
1 parent ab12855 commit 7cfc460
Showing 1 changed file with 17 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1326,12 +1326,23 @@
"type": "string",
"readOnly": true
},
"identityIds": {
"description": "Array of UserAssigned managed service identities.",
"type": "array",
"items": {
"description": "Resource Id for UserAssigned managed service identity",
"type": "string"
"userAssignedIdentities": {
"description": "The list of user assigned identities associated with the resource. The user identity dictionary key references will be ARM resource ids in the form: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ManagedIdentity/userAssignedIdentities/{identityName}",
"type": "object",
"additionalProperties": {
"type": "object",
"properties": {
"principalId": {
"description": "Principal Id of user assigned identity",
"type": "string",
"readOnly": true
},
"clientId": {
"description": "Client Id of user assigned identity",
"type": "string",
"readOnly": true
}
}
}
}
}
Expand Down

0 comments on commit 7cfc460

Please sign in to comment.