Merge remote-tracking branch 'origin/master' into attestation

.azure-pipelines-preproduction/package.json

@@ -11,7 +11,7 @@
   "license": "MIT",
   "devDependencies": {
     "@azure/avocado": "^0.6.4",
-    "@azure/rest-api-specs-scripts": "^0.9.1",
+    "@azure/rest-api-specs-scripts": "^0.10.2",
     "@ts-common/commonmark-to-markdown": "^1.2.0",
     "@ts-common/fs": "0.2.0",
     "@ts-common/iterator": "^0.3.6",
@@ -25,7 +25,8 @@
     "ts-node": "^8.1.0",
     "tslib": "^1.10.0",
     "typescript": "3.5.3",
-    "prettier": "^1.18.2"
+    "prettier": "^1.18.2",
+    "minimist": "^1.2.3"
   },
   "homepage": "https://github.com/azure/azure-rest-api-specs",
   "repository": {

.azure-pipelines/NetworkValidation.yml

@@ -18,7 +18,7 @@ jobs:
     displayName: Install Node.js
   - script: npm install autorest -g
     displayName: Install autorest
-  - script: git clone --depth 1 -- https://dev.azure.com/v-anevse/BuildScripts/_git/BuildScripts ..\BuildScripts
+  - script: git clone --depth 1 -- https://dev.azure.com/nrp-swagger/swagger-stack/_git/automation-scripts ..\BuildScripts
     displayName: Clone build tools
   - powershell: |
       $swgrPath = (Get-Item ".\").FullName

.azure-pipelines/SDKAutomation.yml

@@ -23,6 +23,7 @@ jobs:
       BLOB_STORAGE_PREFIX: sdkautomation-pipeline
       SPEC_REPO: $(Build.Repository.Name)
       PR_NUMBER: $(System.PullRequest.PullRequestNumber)
+      BUILD_ID: $(Build.BuildId)
   strategy:
     matrix:
       Net:
@@ -33,6 +34,8 @@ jobs:
         SDK_REPO_NAME: azure-sdk-for-js
       Python:
         SDK_REPO_NAME: azure-sdk-for-python
+      PythonT2:
+        SDK_REPO_NAME: azure-sdk-for-python-track2
       Cliextension:
         SDK_REPO_NAME: azure-cli-extensions
       Go:
@@ -69,11 +72,14 @@ jobs:
         -e SPEC_REPO \
         -e PR_NUMBER \
         -e SDK_REPO_NAME \
+        -e AZURE_DEVOPS_EXT_PAT \
+        -e BUILD_ID \
         sdk-automation:latest npm start
     env:
       BLOB_STORAGE_NAME: $(blob-storage-name)
       BLOB_STORAGE_KEY: $(blob-storage-key)
       GITHUB_COMMENT_AUTHOR_NAME: $(github-comment-author-name)
       GITHUBAPP_ID: $(githubapp-id)
       GITHUBAPP_PRIVATE_KEY: $(githubapp-private-key)
+      AZURE_DEVOPS_EXT_PAT: $(azure-devops-ext-pat)
     displayName: SDK Automation

.azure-pipelines/azure-pipelines-data-container.yml

@@ -0,0 +1,42 @@
+schedules:
+- cron: "0 0 * * *"
+  displayName: Daily build
+  branches:
+    include:
+    - master
+  always: true
+
+pool:
+  vmImage: 'Ubuntu-16.04'
+
+variables:
+  IMAGE_TAG_PREFIX: $[format('1.0.{0:HHm}', pipeline.startTime)]
+
+steps:
+- task: Docker@2
+  displayName: Login to production ACR
+  inputs:
+    command: login
+    containerRegistry: $(CONTAINER_REGISTRY_SERVICE_CONNECTION)
+
+- task: Docker@2
+  displayName: Login to dogfood ACR
+  inputs:
+    command: login
+    containerRegistry: $(DOGFOOD_CONTAINER_REGISTRY_SERVICE_CONNECTION)
+
+- task: CopyFiles@2
+  inputs:
+    SourceFolder: $(Build.SourcesDirectory)
+    contents: .git/**
+    targetFolder: $(Build.SourcesDirectory)/scripts/datacontainer
+
+- task: Docker@2
+  displayName: Build and Push
+  inputs:
+    command: buildAndPush
+    Dockerfile: scripts/datacontainer/Dockerfile
+    repository: $(CONTAINER_REGISTRY_REPOSITORY_NAME)
+    tags: |
+      latest
+      $(IMAGE_TAG_PREFIX)$(Build.BuildNumber)

.github/PULL_REQUEST_TEMPLATE.md

@@ -2,19 +2,27 @@
 </i>
 
 ### Contribution checklist:
-- [ ] I have reviewed the [documentation](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/202/Overall-Process-of-AME-Onboarding) for the workflow.
-- [ ] [Validation tools](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/84/Swagger-Validation-tools) were run on swagger spec(s) and have all been fixed in this PR. [How to fix?](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md)
+- [ ] I commit to follow the [Breaking Change Policy](http://aka.ms/bcforapi) of “no breaking changes
+- [ ] I have reviewed the [documentation](https://aka.ms/ameonboard) for the workflow.
+- [ ] [Validation tools](https://aka.ms/swaggertools) were run on swagger spec(s) and errors have all been fixed in this PR. [How to fix?](https://aka.ms/ci-fix)
 
-If any further question about AME onboarding or validation tools, please view the [FAQ](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/FAQ.md).
+If any further question about AME onboarding or validation tools, please view the [FAQ](https://aka.ms/faqinprreview).
 
 ### ARM API Review Checklist
-- [ ] Service team MUST add the "**WaitForARMFeedback**" label if the management plane API changes fall into one of the below categories. 
-  - adding/removing APIs.
-  - adding/removing properties.
-  - adding/removing API-version. 
-  - adding a new service in Azure.
+- [ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
+  - Adding new API(s)
+  - Adding a new API version
+  - Adding a new service
 
-<i>Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.</i>
+- [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (*RP Manifest Approvers* team under <ins>Azure Resource Manager service</ins>) from IcM and reach out to them. 
 
-- [ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them. 
-Please follow the link to find more details on [API review process]( https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/212/Swagger-PR-Review).
+### Breaking Change Review Checklist 
+If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the [Breaking Change Policy](http://aka.ms/bcforapi). 
+
+- [ ] Removing API(s) in stable version
+- [ ] Removing properties in stable version
+- [ ] Removing API version(s) in stable version
+- [ ] Updating API in stable version with Breaking Change Validation errors
+- [ ] Updating API(s) in preview over 1 year
+
+Please follow the link to find more details on [PR review process](https://aka.ms/SwaggerPRReview).

.github/pull_request_assignment.yml

@@ -96,6 +96,7 @@
 - rule:
     paths:
       - "specification/mixedreality/**"
+      - "specification/hdinsight/**"
     reviewers:
       - leni-msft