Skip to content

Commit

Permalink
[TimeSeriesInsights] Spec bugfix for GetEvents API - projected proper…
Browse files Browse the repository at this point in the history
…ties are a list of EventProperty and not string. (#5681)

* Fix or suppress spec violations
Fix R2016 by making PATCH body properties optional. Suppress the remaining 4 violations that are confirmed as false positives.

* Try removing 2nd top-level heading, which _may_ have been causing a linter warning.

* Fix extra indention which prevented linter from running.

* Added dataStringComparisonBehavior parameter to reference data put/update spec.

* Fixed grammar.

* adding partitionkeyProperty to environmentInfo

* changing property name

* changing modelAsString

* Initial checkin of spec. Unchanged from GA release other than version.

* Remove .orig files

* Fix validation error by removing IoTHub ES from List ES example response

* Add extra example that was missing from preview spec.

* Add long-term environment to resource hierarchy, and update examples.

* Switch to model-as-string for enums. Restore EnvironmentResource's inheritance from TrackedResource.

* Upsate sku description

* Add new TSI preview api-version to readme.md.

* Add suppressions for false-positive linter failures.

* Test suppression failures

* Adding preview package tag to several other places in readme.md

* Add preview package to the readme.go.md file

* Remove invalid required property from EnvironmentCreateOrUpdateParameters

* Initial version of data plane swagger spec for PAYG (Preview) SKU.

* Added missing Readme.md

* Fixed name of readme

* Fixed path to swagger json

* Attempt to fix readme

* Apply suggestions from code review

Co-Authored-By: dmdenmsft <dmden@microsoft.com>

* Update timeseriesinsights.json

* Update timeseriesinsights.json

* Added link to oav issue

* bug fix - get events payload projected properties to take in list of EventProperty and not string.

* Fixed inconsistencies between examples and spec.

* Fixed bug in spec specifying TSID array.
  • Loading branch information
yeskarthik authored and kpajdzik committed Apr 26, 2019
1 parent c8fec4b commit 97a0c18
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
"inlineVariables": {
"Count": {
"kind": "aggregate",
"value": null,
"filter": null,
"aggregation": {
"tsx": "count()"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
"inlineVariables": {
"Count": {
"kind": "aggregate",
"value": null,
"filter": null,
"aggregation": {
"tsx": "count()"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@
"tsx": "$event.Temperature"
},
"filter": null,
"aggregation": null
"aggregation": {
"tsx": "avg($value)"
}
}
},
"projectedVariables": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@
"tsx": "$event.Temperature"
},
"filter": null,
"aggregation": null
"aggregation": {
"tsx": "avg($value)"
}
}
},
"projectedVariables": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@
"tsx": "$event.Temperature"
},
"filter": null,
"aggregation": null
"aggregation": {
"tsx": "avg($value)"
}
}
},
"projectedVariables": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
"variables": {
"EventCount": {
"kind": "aggregate",
"value": null,
"filter": null,
"aggregation": {
"tsx": "count()"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -971,10 +971,10 @@
"$ref": "#/definitions/Tsx"
},
"projectedProperties": {
"description": "Projected properties is an array of property names which you want to project. These properties must appear in the events.",
"description": "Projected properties is an array of properties which you want to project. These properties must appear in the events; otherwise, they are not returned.",
"type": "array",
"items": {
"type": "string"
"$ref": "#/definitions/EventProperty"
}
}
},
Expand Down Expand Up @@ -1284,10 +1284,7 @@
"properties": {
"get": {
"description": "Time series IDs or names of time series instances to return.",
"type": "array",
"items": {
"$ref": "#/definitions/TimeSeriesId"
}
"$ref": "#/definitions/InstancesRequestBatchGetOrDelete"
},
"put": {
"description": "Time series instances to be created or updated.",
Expand All @@ -1305,10 +1302,7 @@
},
"delete": {
"description": "Time series IDs or names of time series instances to delete.",
"type": "array",
"items": {
"$ref": "#/definitions/TimeSeriesId"
}
"$ref": "#/definitions/InstancesRequestBatchGetOrDelete"
}
}
},
Expand All @@ -1320,8 +1314,7 @@
"description": "List of time series IDs of the time series instances to return or delete.",
"type": "array",
"items": {
"type": "string",
"format": "uuid"
"$ref": "#/definitions/TimeSeriesId"
}
},
"names": {
Expand Down

0 comments on commit 97a0c18

Please sign in to comment.