Adding xms ids to azsadmin (#17724)

* Adding xms-ids for AzsAdmin - rebased * reverting stale changes * Adding additional xms * prettier fix
Azure · Feb 10, 2022 · becbf3c · becbf3c
1 parent b3a0b98
commit becbf3c
Show file tree

Hide file tree

Showing 37 changed files with 404 additions and 228 deletions.
diff --git a/...source-manager/azurebridge/Microsoft.AzureBridge.Admin/preview/2016-01-01/Activation.json b/...source-manager/azurebridge/Microsoft.AzureBridge.Admin/preview/2016-01-01/Activation.json
@@ -38,7 +38,10 @@
             "description": "OK",
             "schema": {
               "$ref": "#/definitions/ActivationResourcesPage"
-            }
+            },
+            "x-ms-identifiers": [
+              "id"
+            ]
           },
           "default": {
             "description": "Default Response.",
@@ -298,6 +301,7 @@
           "items": {
             "$ref": "#/definitions/ErrorDefinition"
           },
+          "x-ms-identifiers": [],
           "readOnly": true
         }
       }

diff --git a/...ource-manager/azurebridge/Microsoft.AzureBridge.Admin/preview/2016-01-01/AzureBridge.json b/...ource-manager/azurebridge/Microsoft.AzureBridge.Admin/preview/2016-01-01/AzureBridge.json
@@ -143,6 +143,9 @@
           "items": {
             "$ref": "#/definitions/Operation"
           },
+          "x-ms-identifiers": [
+            "name"
+          ],
           "readOnly": true
         },
         "nextLink": {
@@ -286,7 +289,10 @@
       "type": "array",
       "items": {
         "$ref": "#/definitions/ProductLink"
-      }
+      },
+      "x-ms-identifiers": [
+        "uri"
+      ]
     },
     "Compatibility": {
       "description": "Product compatibility",
@@ -460,6 +466,9 @@
           "items": {
             "$ref": "#/definitions/DataDiskImage"
           },
+          "x-ms-identifiers": [
+            "sourceBlobSasUri"
+          ],
           "readOnly": true
         }
       }

diff --git a/...n/azsadmin/resource-manager/backup/Microsoft.Backup.Admin/preview/2021-09-01/Backups.json b/...n/azsadmin/resource-manager/backup/Microsoft.Backup.Admin/preview/2021-09-01/Backups.json
@@ -276,7 +276,10 @@
       "type": "array",
       "items": {
         "$ref": "#/definitions/RoleOperationStatus"
-      }
+      },
+      "x-ms-identifiers": [
+        "roleName"
+      ]
     },
     "RoleOperationStatus": {
       "description": "Backup status for a role.",

diff --git a/...ion/azsadmin/resource-manager/backup/Microsoft.Backup.Admin/stable/2018-09-01/Backup.json b/...ion/azsadmin/resource-manager/backup/Microsoft.Backup.Admin/stable/2018-09-01/Backup.json
@@ -135,6 +135,9 @@
           "items": {
             "$ref": "#/definitions/Operation"
           },
+          "x-ms-identifiers": [
+            "name"
+          ],
           "readOnly": true
         },
         "nextLink": {

diff --git a/...source-manager/commerce/Microsoft.Commerce.Admin/preview/2015-06-01-preview/Commerce.json b/...source-manager/commerce/Microsoft.Commerce.Admin/preview/2015-06-01-preview/Commerce.json
@@ -88,17 +88,17 @@
           }
         ],
         "responses": {
-          "default": {
-            "description": "Default Response.",
-            "schema": {
-              "$ref": "#/definitions/ExtendedErrorInfo"
-            }
-          },
           "200": {
             "description": "OK",
             "schema": {
               "$ref": "#/definitions/UsageAggregatePage"
             }
+          },
+          "default": {
+            "description": "Default Response.",
+            "schema": {
+              "$ref": "#/definitions/ExtendedErrorInfo"
+            }
           }
         },
         "x-ms-pageable": {
@@ -127,14 +127,14 @@
           }
         ],
         "responses": {
+          "200": {
+            "description": "OK"
+          },
           "default": {
             "description": "Default Response.",
             "schema": {
               "$ref": "#/definitions/ExtendedErrorInfo"
             }
-          },
-          "200": {
-            "description": "OK"
           }
         }
       }
@@ -300,7 +300,10 @@
           "type": "array",
           "items": {
             "$ref": "#/definitions/Operation"
-          }
+          },
+          "x-ms-identifiers": [
+            "name"
+          ]
         },
         "nextLink": {
           "description": "URI to the next page of operations.",
@@ -338,6 +341,7 @@
           "items": {
             "$ref": "#/definitions/ErrorDefinition"
           },
+          "x-ms-identifiers": [],
           "readOnly": true
         }
       }

diff --git a/.../resource-manager/compute/Microsoft.Compute.Admin/preview/2015-12-01-preview/Compute.json b/.../resource-manager/compute/Microsoft.Compute.Admin/preview/2015-12-01-preview/Compute.json
@@ -168,7 +168,10 @@
           "type": "array",
           "items": {
             "$ref": "#/definitions/Operation"
-          }
+          },
+          "x-ms-identifiers": [
+            "name"
+          ]
         },
         "nextLink": {
           "description": "URI to the next page of operations.",

diff --git a/...ce-manager/compute/Microsoft.Compute.Admin/preview/2015-12-01-preview/PlatformImages.json b/...ce-manager/compute/Microsoft.Compute.Admin/preview/2015-12-01-preview/PlatformImages.json
@@ -208,14 +208,14 @@
           }
         ],
         "responses": {
+          "200": {
+            "description": "OK"
+          },
           "default": {
             "description": "Common error response for all Azure Resource Manager APIs to return error details for failed operations. (This also follows the OData error response format.).",
             "schema": {
               "$ref": "Compute.json#/definitions/CrpErrorResponse"
             }
-          },
-          "200": {
-            "description": "OK"
           }
         }
       }
@@ -251,7 +251,10 @@
           "type": "array",
           "items": {
             "$ref": "#/definitions/DataDisk"
-          }
+          },
+          "x-ms-identifiers": [
+            "lun"
+          ]
         },
         "details": {
           "description": "Information about the image.",

diff --git a/...sadmin/resource-manager/compute/Microsoft.Compute.Admin/stable/2021-03-30/ScaleUnits.json b/...sadmin/resource-manager/compute/Microsoft.Compute.Admin/stable/2021-03-30/ScaleUnits.json
@@ -93,7 +93,10 @@
           "type": "array",
           "items": {
             "$ref": "#/definitions/NodeView"
-          }
+          },
+          "x-ms-identifiers": [
+            "nodeName"
+          ]
         }
       }
     },
@@ -127,7 +130,10 @@
           "type": "array",
           "items": {
             "$ref": "#/definitions/VirtualMachineView"
-          }
+          },
+          "x-ms-identifiers": [
+            "vmId"
+          ]
         }
       }
     },

diff --git a/...resource-manager/compute/Microsoft.Compute.Admin/stable/2021-09-01/DiskMigrationJobs.json b/...resource-manager/compute/Microsoft.Compute.Admin/stable/2021-09-01/DiskMigrationJobs.json
@@ -43,17 +43,17 @@
           }
         ],
         "responses": {
-          "default": {
-            "description": "Error response describing why the operation failed.",
-            "schema": {
-              "$ref": "#/definitions/ErrorResponse"
-            }
-          },
           "200": {
             "description": "OK -- The list of disk migration jobs has been returned.",
             "schema": {
               "$ref": "DiskMigrationJobs.json#/definitions/DiskMigrationJobList"
             }
+          },
+          "default": {
+            "description": "Error response describing why the operation failed.",
+            "schema": {
+              "$ref": "#/definitions/ErrorResponse"
+            }
           }
         },
         "x-ms-pageable": {
@@ -88,17 +88,17 @@
           }
         ],
         "responses": {
-          "default": {
-            "description": "Error response describing why the operation failed.",
-            "schema": {
-              "$ref": "#/definitions/ErrorResponse"
-            }
-          },
           "200": {
             "description": "OK -- The disk migration job has been returned.",
             "schema": {
               "$ref": "DiskMigrationJobs.json#/definitions/DiskMigrationJob"
             }
+          },
+          "default": {
+            "description": "Error response describing why the operation failed.",
+            "schema": {
+              "$ref": "#/definitions/ErrorResponse"
+            }
           }
         }
       },
@@ -140,17 +140,17 @@
           }
         ],
         "responses": {
-          "default": {
-            "description": "Error response describing why the operation failed.",
-            "schema": {
-              "$ref": "#/definitions/ErrorResponse"
-            }
-          },
           "200": {
             "description": "OK --  Disk migration job is created successfully.",
             "schema": {
               "$ref": "DiskMigrationJobs.json#/definitions/DiskMigrationJob"
             }
+          },
+          "default": {
+            "description": "Error response describing why the operation failed.",
+            "schema": {
+              "$ref": "#/definitions/ErrorResponse"
+            }
           }
         }
       }
@@ -182,17 +182,17 @@
           }
         ],
         "responses": {
-          "default": {
-            "description": "Error response describing why the operation failed.",
-            "schema": {
-              "$ref": "#/definitions/ErrorResponse"
-            }
-          },
           "200": {
             "description": "OK --  Disk migration job cancellation is called.",
             "schema": {
               "$ref": "DiskMigrationJobs.json#/definitions/DiskMigrationJob"
             }
+          },
+          "default": {
+            "description": "Error response describing why the operation failed.",
+            "schema": {
+              "$ref": "#/definitions/ErrorResponse"
+            }
           }
         }
       }
@@ -319,7 +319,10 @@
       "type": "array",
       "items": {
         "$ref": "DiskMigrationJobs.json#/definitions/MigrationSubTask"
-      }
+      },
+      "x-ms-identifiers": [
+        "migrationSubTaskId"
+      ]
     },
     "MigrationSubTask": {
       "description": "Disk migration child task.",

diff --git a/...inerregistry/Microsoft.ContainerRegistry.Admin/preview/2019-11-01-preview/operations.json b/...inerregistry/Microsoft.ContainerRegistry.Admin/preview/2019-11-01-preview/operations.json
@@ -106,7 +106,10 @@
           "type": "array",
           "items": {
             "$ref": "#/definitions/Operation"
-          }
+          },
+          "x-ms-identifiers": [
+            "name"
+          ]
         }
       }
     }

diff --git a/specification/azsadmin/resource-manager/containerregistry/readme.md b/specification/azsadmin/resource-manager/containerregistry/readme.md
@@ -24,12 +24,12 @@ These are the global settings for the ContainerRegistry API.
 title: ContainerRegistryAdminClient
 description: ContainerRegistry Admin Client
 openapi-type: arm
-tag: package-2019-11-01
+tag: package-2019-11-01-preview
 ```
 
-### Tag: package-2019-11-01
+### Tag: package-2019-11-01-preview
 
-These settings apply only when `--tag=package-2019-11-01` is specified on the command line.
+These settings apply only when `--tag=package-2019-11-01-preview` is specified on the command line.
 
 ``` yaml $(tag) == 'package-2019-11-01-preview'
 input-file:
@@ -86,4 +86,3 @@ uncomment the  `exclude-file` section below and add the file paths.
 #exclude-file: 
 #  - $(this-folder)/Microsoft.Example/stable/2010-01-01/somefile.json
 ```
-
diff --git a/...nager/containerservice/Microsoft.ContainerService.Admin/stable/2019-11-01/operations.json b/...nager/containerservice/Microsoft.ContainerService.Admin/stable/2019-11-01/operations.json
@@ -109,7 +109,10 @@
           "type": "array",
           "items": {
             "$ref": "#/definitions/Operation"
-          }
+          },
+          "x-ms-identifiers": [
+            "name"
+          ]
         },
         "nextLink": {
           "description": "URI to the next page.",

diff --git a/...resource-manager/deployment/Microsoft.Deployment.Admin/preview/2019-01-01/Deployment.json b/...resource-manager/deployment/Microsoft.Deployment.Admin/preview/2019-01-01/Deployment.json
@@ -104,6 +104,7 @@
           "items": {
             "$ref": "#/definitions/ErrorDefinition"
           },
+          "x-ms-identifiers": [],
           "readOnly": true
         }
       }
@@ -164,7 +165,10 @@
           "type": "array",
           "items": {
             "$ref": "#/definitions/Operation"
-          }
+          },
+          "x-ms-identifiers": [
+            "name"
+          ]
         },
         "nextLink": {
           "description": "URI to the next page of operations.",

diff --git a/...ource-manager/deployment/Microsoft.Deployment.Admin/preview/2019-01-01/FileContainer.json b/...ource-manager/deployment/Microsoft.Deployment.Admin/preview/2019-01-01/FileContainer.json
@@ -251,7 +251,8 @@
           "type": "array",
           "items": {
             "$ref": "#/definitions/ErrorInfo"
-          }
+          },
+          "x-ms-identifiers": []
         }
       }
     },

diff --git a/...urce-manager/deployment/Microsoft.Deployment.Admin/preview/2019-01-01/ProductPackage.json b/...urce-manager/deployment/Microsoft.Deployment.Admin/preview/2019-01-01/ProductPackage.json
@@ -269,7 +269,10 @@
       "type": "array",
       "items": {
         "$ref": "#/definitions/ProductLink"
-      }
+      },
+      "x-ms-identifiers": [
+        "uri"
+      ]
     },
     "ProductPackageParameters": {
       "description": "Parameters for creating a new product package.",