Merge branch 'master' into dhsawhne/updateBackendAddress

.azure-pipelines-preproduction/package.json

@@ -25,7 +25,8 @@
     "ts-node": "^8.1.0",
     "tslib": "^1.10.0",
     "typescript": "3.5.3",
-    "prettier": "^1.18.2"
+    "prettier": "^1.18.2",
+    "minimist": "^1.2.3"
   },
   "homepage": "https://github.com/azure/azure-rest-api-specs",
   "repository": {

.azure-pipelines/azure-pipelines-data-container.yml

@@ -0,0 +1,42 @@
+schedules:
+- cron: "0 0 * * *"
+  displayName: Daily build
+  branches:
+    include:
+    - master
+  always: true
+
+pool:
+  vmImage: 'Ubuntu-16.04'
+
+variables:
+  IMAGE_TAG_PREFIX: $[format('1.0.{0:HHm}', pipeline.startTime)]
+
+steps:
+- task: Docker@2
+  displayName: Login to production ACR
+  inputs:
+    command: login
+    containerRegistry: $(CONTAINER_REGISTRY_SERVICE_CONNECTION)
+
+- task: Docker@2
+  displayName: Login to dogfood ACR
+  inputs:
+    command: login
+    containerRegistry: $(DOGFOOD_CONTAINER_REGISTRY_SERVICE_CONNECTION)
+
+- task: CopyFiles@2
+  inputs:
+    SourceFolder: $(Build.SourcesDirectory)
+    contents: .git/**
+    targetFolder: $(Build.SourcesDirectory)/scripts/datacontainer
+
+- task: Docker@2
+  displayName: Build and Push
+  inputs:
+    command: buildAndPush
+    Dockerfile: scripts/datacontainer/Dockerfile
+    repository: $(CONTAINER_REGISTRY_REPOSITORY_NAME)
+    tags: |
+      latest
+      $(IMAGE_TAG_PREFIX)$(Build.BuildNumber)

.github/PULL_REQUEST_TEMPLATE.md

@@ -2,19 +2,27 @@
 </i>
 
 ### Contribution checklist:
+- [ ] I commit to follow the [Breaking Change Policy](http://aka.ms/bcforapi) of “no breaking changes
 - [ ] I have reviewed the [documentation](https://aka.ms/ameonboard) for the workflow.
-- [ ] [Validation tools](https://aka.ms/swaggertools) were run on swagger spec(s) and have all been fixed in this PR. [How to fix?](https://aka.ms/ci-fix)
+- [ ] [Validation tools](https://aka.ms/swaggertools) were run on swagger spec(s) and errors have all been fixed in this PR. [How to fix?](https://aka.ms/ci-fix)
 
 If any further question about AME onboarding or validation tools, please view the [FAQ](https://aka.ms/faqinprreview).
 
 ### ARM API Review Checklist
-- [ ] Service team MUST add the "**WaitForARMFeedback**" label if the management plane API changes fall into one of the below categories. 
-  - adding/removing APIs.
-  - adding/removing properties.
-  - adding/removing API-version. 
-  - adding a new service in Azure.
+- [ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
+  - Adding new API(s)
+  - Adding a new API version
+  - Adding a new service
 
-<i>Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.</i>
+- [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (*RP Manifest Approvers* team under <ins>Azure Resource Manager service</ins>) from IcM and reach out to them. 
 
-- [ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them. 
-Please follow the link to find more details on [API review process](https://aka.ms/SwaggerPRReview).
+### Breaking Change Review Checklist 
+If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the [Breaking Change Policy](http://aka.ms/bcforapi). 
+
+- [ ] Removing API(s) in stable version
+- [ ] Removing properties in stable version
+- [ ] Removing API version(s) in stable version
+- [ ] Updating API in stable version with Breaking Change Validation errors
+- [ ] Updating API(s) in preview over 1 year
+
+Please follow the link to find more details on [PR review process](https://aka.ms/SwaggerPRReview).

.github/pull_request_assignment.yml

@@ -96,6 +96,7 @@
 - rule:
     paths:
       - "specification/mixedreality/**"
+      - "specification/hdinsight/**"
     reviewers:
       - leni-msft
 

CODEOWNERS

@@ -12,10 +12,10 @@
 /specification/cognitiveservices/ @felixwa @yangyuan
 /specification/compute/ @hyonholee @mabhard @danielli90 @smotwani @ppatwa @vikramd-ms @savyasachisamal @yunusm @ZhidongPeng @nkuchta @maheshnemichand @najams @changov
 /specification/consumption/ @kjeur @panda-wang
-/specification/containerinstance/ @samkreter
+/specification/containerinstance/ @novinc
 /specification/containerregistry/ @djyou
 /specification/containerservice/ @yangl900
-/specification/cosmos-db/ @dmakwana
+/specification/cosmos-db/ @dmakwana @MehaKaushik @wmengmsft @shurd
 /specification/customer-insights/ @tjlvtao
 /specification/datafactory/ @zhangyd2015
 /specification/datalake-analytics/ @ro-joowan
@@ -74,5 +74,5 @@
 /specification/subscriptions/ @navysingla
 /specification/timeseriesinsights/ @sandshadow
 /specification/trafficmanager/ @allencal @hrkulkarmsft
-/specification/web/ @lukaszstem @naveedaz @nking92
+/specification/web/ @naveedaz @Azure/azure-app-service-control-plane
 /profile/ @shahabhijeet

cSpell.json

@@ -2,6 +2,7 @@
     "version": "0.1",
     "language": "en",
     "words": [
+        "Creds"
     ],
     "dictionaryDefinitions": [
         {
@@ -636,4 +637,4 @@
             ]
         }
     ]
-}
+}

custom-words.txt

@@ -57,6 +57,7 @@ Annotatable
 anomalydetector
 anomalyfinder
 APAC
+APACHEAVRO
 API's
 apim
 apimanagement
@@ -100,6 +101,8 @@ applynetworkconfigurationupdates
 appservice
 appsettings
 appteststorage
+ABGRABGR
+ARGBARGB
 Arjun
 armtemplates
 arpa
@@ -191,6 +194,10 @@ BCDR
 BCWG
 beider
 Bfor
+bfqt
+BGRA
+BGRABGRA
+BGRBGR
 bigint
 Bigram
 bigrams
@@ -207,6 +214,7 @@ bingspellcheck
 bingvideosearch
 bingvisualsearch
 bingwebsearch
+Bioconductor
 Bitbucket
 Bitlocker
 bitness
@@ -278,6 +286,7 @@ clientgroup
 clientlib
 clipart
 CLIs
+CLOGFILE
 Cloneability
 Cloneable
 closedlist
@@ -338,6 +347,7 @@ costmanagement
 Couchbase
 cpim
 CPIM
+Cran
 creatable
 createconsumergroup
 createorupdate
@@ -585,6 +595,7 @@ GC'd
 GCMAES
 gdpr
 genderless
+generatelivetoken
 generateverificationcode
 generatevpnclientpackage
 generatevpnprofile
@@ -761,6 +772,7 @@ jumpbox
 jwts
 kafkarest
 Kaliningrad
+kbid
 Kbps
 KECA
 kernelspec
@@ -923,7 +935,9 @@ modelmanagement
 MODIFYACLENTRIES
 monitoringconfiguration
 monitoringconfigurations
+Monospace
 MPNS
+MRAN
 MSAZR
 MSAZRDE
 MSCONCAT
@@ -942,6 +956,7 @@ multistep
 multivalued
 muxed
 MUXes
+muxer
 muxing
 mware
 myanalytics
@@ -1024,6 +1039,7 @@ octokit
 Odata
 odatatype
 ODBC
+officedocument
 OLTP
 onboarded
 Onboarding
@@ -1040,6 +1056,7 @@ openapi
 opencode
 opencontainers
 openid
+openxmlformats
 operationalinsights
 Operationalization
 operationresults
@@ -1148,6 +1165,7 @@ Protectable
 provisioner
 provisioningservices
 Psec
+PSNR
 ptrdname
 publicipaddresses
 publicpreview
@@ -1159,6 +1177,7 @@ pullrequest
 Purgeable
 pushdown
 pushsettings
+pwsh
 Pyspark
 pytorch
 QFEs
@@ -1167,6 +1186,7 @@ qloguniform
 qnamaker
 qnas
 qnormal
+Qssw
 querylogs
 querypool
 querystring
@@ -1285,6 +1305,8 @@ Retryable
 Revalidates
 Revertable
 REVOKEACE
+RGBARGBA
+RGBRGB
 rgname
 rhel
 Rolledback
@@ -1305,6 +1327,7 @@ rscc
 rscd
 rsce
 rscl
+rscript
 rsct
 Rslp
 RSNULL
@@ -1316,6 +1339,7 @@ runcounts
 runid
 runsource
 runtimes
+rwdlacup
 rwxrw
 Saas
 salesforcetables
@@ -1358,6 +1382,7 @@ servicefabricmesh
 servicefabrics
 servicemap
 servicemembers
+serviceprincipal
 servicerunners
 servicestats
 servicetopology
@@ -1425,9 +1450,11 @@ sparkconf
 sparql
 SPDX
 SQLAG
+sqldatabase
 SQLDB
 SQLDW
 SQLMI
+sqlpool
 SQLRDS
 sqlvirtualmachine
 sqlvm
@@ -1455,6 +1482,7 @@ storageaccount
 storageaccounts
 storagedatalake
 storageimportexport
+storagesources
 storagesync
 storagetarget
 storageuri
@@ -1464,6 +1492,7 @@ streamingendpoint
 streamingjobs
 streamingservice
 subcomponent
+subdir
 subdomain
 subexpressions
 subfolder
@@ -1562,6 +1591,7 @@ trafficmanageranalytics
 trafficmanagerprofiles
 tráfico
 transcoding
+transcodes
 transcriptmoderationresult
 translatortext
 trendingtopics
@@ -1701,6 +1731,7 @@ vsphere
 VSTS
 VSTSRM
 VXLAN
+W3CLOGFILE
 waagent
 WADL
 waitforjobcompletion
@@ -1735,11 +1766,13 @@ WGXM
 whitelisted
 Whitelisting
 Whitelistings
+whitespaces
 Whois
 Widevine
 windowsazuremediaservices
 windowsesu
 wlmengg
+wordprocessingml
 workbooktemplates
 Workernode
 workloadmonitor
@@ -1753,6 +1786,7 @@ XBing
 Xeon
 Xero
 XSMB
+XVCJ
 Yucatec
 Ywhk
 YYMMDD
@@ -1785,6 +1819,16 @@ userprincipalname
 sessionstate
 sessionhosts
 hostpool
+securitydomain
+securitydomaindownloadpost
+securitydomaintransferkey
+securitydomainuploadoperation
+securitydomainoperationstatus
+transferkey
+Alexa
+regeneratekeys
+Directline
+Keyschannel
 azureADMetrics
 sparkr
 ambari

documentation/ci-fix.md

@@ -91,3 +91,6 @@ Note: When running in Swagger PR pipeline, Avocado only report errors with file
 
 Refer to [Avocado Readme](https://github.com/Azure/avocado/blob/master/README.md) for detailed description of validations and how-to-fix guidance.
 
+## Suppression Process
+
+In case there are validation errors reported against your service that you believe do not apply, we have a suppression process you can follow to permanently remove these reported errors for your specs.  Refer to [Swagger Suppression Process](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/85/Swagger-Suppression-Process) for detailed guidance.