Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceGuardProxy - missing PUT parameter resourceGuardResourceId #20953

Closed
ziyeqf opened this issue Sep 30, 2022 · 4 comments · Fixed by #21290
Closed

ResourceGuardProxy - missing PUT parameter resourceGuardResourceId #20953

ziyeqf opened this issue Sep 30, 2022 · 4 comments · Fixed by #21290
Assignees
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. customer-reported Issues that are reported by GitHub users external to the Azure organization. Recovery Services Backup

Comments

@ziyeqf
Copy link
Contributor

ziyeqf commented Sep 30, 2022

swagger link: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2021-12-01/bms.json#L4362

example link: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/recoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2021-12-01/examples/ResourceGuardProxyCRUD/PutResourceGuardProxy.json

In the swagger file, there is no parameter named resourceGuardResourceId in ResourceGuardProxy_Put while in the example there is. the parameter is needed to create.

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Sep 30, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 20, 2022
@navba-MSFT navba-MSFT self-assigned this Oct 26, 2022
@navba-MSFT
Copy link
Contributor

@ziyeqf Apologies for the late reply. Thanks for reaching out to us and reporting this issue. We are looking into this issue and we will provide an update.

@navba-MSFT
Copy link
Contributor

@ziyeqf AFAIK, the PUT operation is using the schema definition from ResourceGuardProxyBaseResource which inturn gets the definition reference from ResourceGuardProxyBase which has the property resourceGuardResourceId.

Sending you the below details if that helps.

"200": {
"description": "OK",
"schema": {
"$ref": "#/definitions/ResourceGuardProxyBaseResource"
}
},

"ResourceGuardProxyBaseResource": {
"allOf": [
{
"$ref": "#/definitions/Resource"
}
],
"type": "object",
"properties": {
"properties": {
"$ref": "#/definitions/ResourceGuardProxyBase",
"description": "ResourceGuardProxyBaseResource properties"
}
}
},

"ResourceGuardProxyBase": {
"type": "object",
"properties": {
"resourceGuardResourceId": {
"type": "string"
},
"resourceGuardOperationDetails": {

@navba-MSFT navba-MSFT added the needs-author-feedback Workflow: More information is needed from author to address the issue. label Oct 26, 2022
@ziyeqf
Copy link
Contributor Author

ziyeqf commented Oct 26, 2022

@navba-MSFT Thanks for your insight.

But it seems the ResourceGuardProxyBase is referenced in response of ResourceGuardProxy_Put, rather than parameters. and it's needed in parameters.

@ghost ghost added needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team and removed needs-author-feedback Workflow: More information is needed from author to address the issue. labels Oct 26, 2022
@navba-MSFT
Copy link
Contributor

@ziyeqf The above PR is currently under review.

@navba-MSFT navba-MSFT added bug This issue requires a change to an existing behavior in the product in order to be resolved. Recovery Services Backup and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team labels Oct 27, 2022
azure-sdk pushed a commit to azure-sdk/azure-resource-manager-schemas that referenced this issue Nov 29, 2022
anandanthony pushed a commit to anandMicro/azure-rest-api-specs that referenced this issue Dec 16, 2022
kayousef-zz pushed a commit to kayousef-zz/azure-rest-api-specs that referenced this issue Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. customer-reported Issues that are reported by GitHub users external to the Azure organization. Recovery Services Backup
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants