Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Firewall: internalPublicIpAddress vs publicIPAddress #3474

Closed
hbuckle opened this issue Jul 22, 2018 · 0 comments
Closed

Azure Firewall: internalPublicIpAddress vs publicIPAddress #3474

hbuckle opened this issue Jul 22, 2018 · 0 comments
Labels
Network Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@hbuckle
Copy link

hbuckle commented Jul 22, 2018 •
edited by azuresdkci
Loading

When creating or updating an Azure Firewall the internalPublicIpAddress property is required, but in responses this property is returned as publicIPAddress
This causes a problem when getting an existing firewall and updating the properties because I have to rename publicIPAddress to internalPublicIpAddress before sending the request back.
Is there any reason for the difference in property names?
@hbuckle hbuckle mentioned this issue Jul 24, 2018
Merged
lmazuel pushed a commit that referenced this issue Aug 30, 2018
@fanymanea @lmazuel
Use only PublicIpAddress in Azure Firewall, not both Public and Inter…
7100b4f 
…nalPublic (#3743)

* Do not confuse users with both InternalPublicIp and PublicIp for the same thing

* Update AzureFirewall PUT example

* This closes #3474

* Use the correct name for publicIPAddress in AzureFirewall PUT example
sergey-shandar pushed a commit that referenced this issue Sep 10, 2018
@ritwikbasu @sergey-shandar
Brooklyn Ignite Swagger changes (#3715)
40cca9d 
* Brooklyn Ignite Swagger changes

* Add missing example file changes

* Add virtual hub route table

* Fix travis build error

* VPN profile bugfix

* Fix casing for NRP automapping

* Fix parsing errors

* remove BgpSettings from P2SVpnGateway object

* Added AddressPrefixes on Subnet properties (#3714)

* Added address prefixes to subnet

* Added example of multiple address prefixes.

* Python Network conf 2018-08-01

* Changes to include required properties for outbound rule (#3728)

* Mark outbound rule properties as required

* Update outbound rule with required properties

* Removing old change

* Fix Python 2018-08 conf

* Fix swagger contract errors with NRP

* Fix network swagger

* Fix virtualHub Properties for SDK and PS JSON serializer compliance

* Fix bugs

* Changing Cortex swagger to match NRP

* Bug fixes

* bugFix3

* Bug fix

* Use only PublicIpAddress in Azure Firewall, not both Public and InternalPublic (#3743)

* Do not confuse users with both InternalPublicIp and PublicIp for the same thing

* Update AzureFirewall PUT example

* This closes #3474

* Use the correct name for publicIPAddress in AzureFirewall PUT example

* Azure Firewall FQDN Tag top level resource (#3744)

* Azure Firewall FQDN Tag top level resource

* Name FqdnTags property in AzureFirewallApplicationRule properly

* Empty commit to trigger new validation

* Vtapfinal (#3684)

* Swagger Coverage/Completeness- for operation CheckNameAvailability (#3663)

* Update service.json

* CheckNameAvailability

* FIxed Parameter name

fixed couple of parameters name

* Adds base for updating Microsoft.Network from version stable/2018-07-01 to version 2018-08-01

* Updates readme

* Updates API version in new specs and examples

* vtap update

* VTAP changes

* VTAP changes

* Adding examples for VTAP resource

* Update changes for Examples

* Further fixes to examples

* Add exception for vtap's RequiredPropertiesMissingInResourceModel in readme

* Azure Firewall NAT Rule Collection (#3745)

* NAT Rule Collections for Azure Firewall

* Update examples to include the new NAT Rule Collection

* Shorten the NAT RC Properties name and mark etag read-only

* Add NAT Rule Collection to Azure Firewall properties

* Fix all <<a Azure>> in helper messages

* Do not allow ICMP as Network protocol (#3742)

* Adding linkedResourceType and hostedWorkloads to nic (#3780)

* Adding support for interface endpoints (#3783)

* Creating Interface Endpoint definition

* Adding references to interface endpoints in existing resources

* Added Trusted root certificate changes to new API version (#3731)

* Add ExpressRoute gateway resource (#3776)

* Initial version

* Refactor connections.

* Update API version

* Add enum values.

* Addressed all comments.

* Adding support for delegations on a subnet (#3805)

* Adding subnet delegation property on VNET

* Updating subnet/vnet create & get examples to reflect delegation

* Adding support for GetAvailableDelegations operation

* Fixing properties in Swagger & updating examples to reflect fixes

* Add availableDelegation as a subResource

* Remove type from examples

* Further updates to delegation PR

* Additional changes to structure

* Correct issues for SDK generation (#3818)

* Remove x-ms-client-flatten attribute as that results in wrong
descriptiosn during generation of the SDKs.

* Missing descriptions.

* Rename TargetUrls to TargetFqdns (#3739)

* Fix travis errors in examples

* Fixed error examples for P2S cortex resources

* Fix swagger

* Fix Semantic validation error

* network swagger fix

* Fix travis

* Fix travis errors

* Revert version change

* Dummy changes for CI restart
@bsiegel bsiegel added the Service Attention Workflow: This issue is responsible by Azure service team. label Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Network Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bsiegel @jhendrixMSFT @hbuckle @joannakleong